Adding name suffix to filestore instances def name. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it was, if the user created two Filestore instances without specifying their name, there would be a name clash.
heyealex
approved these changes
Oct 15, 2021
nick-stroud
referenced
this pull request
in nick-stroud/hpc-toolkit
Jul 8, 2022
Transition to automatically generated instance template for cloud-batch-job module
nick-stroud
pushed a commit
that referenced
this pull request
Aug 14, 2024
OFE: tweak to valid drive types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was, if the user created two Filestore instances without
specifying their name, there would be a name clash.