Improved Startup scripts #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now startup scripts only need a single metadata entry (startup_script). startup_script_custom is no longer needed.
It is now possible to specify runners with the following structures:
runners:
- type: shell
file: "modules/startup-script/examples/install_ansible.sh"
- type: shell
name: "test.sh"
content:<<EOT
#!/bin/sh
echo this is a test
<<EOT
Runners now take type, source | content, destination. Changed the Omnia example, the documentation, and tests.
heyealex
suggested changes
Dec 14, 2021
cboneti
force-pushed
the
startup-scripts
branch
from
46da00f
to
692c3a4
Compare
Added a parameter "args" to the runners. It is only used with Shell scripts.
cboneti
force-pushed
the
startup-scripts
branch
from
692c3a4
to
443de9a
Compare
heyealex
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist:
pre-commit installmake testschange?
guides?