Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor typos in README #63

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Fix minor typos in README #63

merged 1 commit into from
Dec 23, 2021

Conversation

mittz
Copy link
Contributor

@mittz mittz commented Dec 22, 2021

  • Fix the sample directory path using the example value in the "Basic Usage" section.
  • Fix the Markdown typo in the "Development" section.

Submission Checklist:

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

heyealex
heyealex approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@heyealex heyealex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixes these! Approved, feel free to merge when ready.

@mittz mittz merged commit 97dccd5 into GoogleCloudPlatform:develop Dec 23, 2021
@mittz mittz deleted the fix-readme-typos branch December 23, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyealex heyealex heyealex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mittz @heyealex