Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject build id into Omnia test, drop to last build #832

Merged

Conversation

heyealex
Copy link
Contributor

There have been known issues with the naming of the resources created by the omnia example in automated testing. In order to allow parallel builds, this PR injects the build ID into the name prefix before running the test.

More thorough fixes are possible, but are not a priority for now. In addition, the test has been dropped to last in the group to ensure that all other tests can run if Omnia fails due to changes outside of our teams control.

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

There have been known issues with the naming of the resources created by
the omnia example in automated testing. In order to allow parallel
builds, this PR injects the build ID into the name prefix before running
the test.

More thorough fixes are possible, but are not a priority for now. In
addition, the test has been dropped to last in the group to ensure that
all other tests can run if Omnia fails due to changes outside of our
teams control.
@nick-stroud nick-stroud assigned heyealex and unassigned nick-stroud Jan 12, 2023
@heyealex
Copy link
Contributor Author

I'm running tests against all groups that use the base-integration-test.yml playbook to be safe. It is ready to be reviewed again, but I will not merge until they all pass.

@nick-stroud nick-stroud assigned heyealex and unassigned nick-stroud Jan 12, 2023
@heyealex heyealex merged commit 76ee0ef into GoogleCloudPlatform:develop Jan 13, 2023
@heyealex heyealex deleted the bugfix/omnia-disk-naming branch January 13, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants