-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCS bucket module #836
Merged
nick-stroud
merged 10 commits into
GoogleCloudPlatform:develop
from
nick-stroud:gcs_bucket_module
Jan 19, 2023
Merged
GCS bucket module #836
nick-stroud
merged 10 commits into
GoogleCloudPlatform:develop
from
nick-stroud:gcs_bucket_module
Jan 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-stroud
force-pushed
the
gcs_bucket_module
branch
from
January 17, 2023 18:07
def55f6
to
f853a71
Compare
heyealex
suggested changes
Jan 17, 2023
community/modules/file-system/cloud-storage-bucket/variables.tf
Outdated
Show resolved
Hide resolved
nick-stroud
force-pushed
the
gcs_bucket_module
branch
from
January 18, 2023 15:31
817aa59
to
c384841
Compare
heyealex
reviewed
Jan 18, 2023
community/modules/file-system/cloud-storage-bucket/variables.tf
Outdated
Show resolved
Hide resolved
nick-stroud
force-pushed
the
gcs_bucket_module
branch
2 times, most recently
from
January 18, 2023 23:23
67b7bce
to
228b10f
Compare
nick-stroud
force-pushed
the
gcs_bucket_module
branch
from
January 18, 2023 23:24
228b10f
to
0b76dfb
Compare
heyealex
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for making the changes!
I still have one comment open, feel free to close it if you don't think the update is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a module that creates a Google Cloud Storage bucket.
Submission Checklist
pre-commit install
)make tests
)