Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS bucket module #836

Merged
merged 10 commits into from
Jan 19, 2023

Conversation

nick-stroud
Copy link
Collaborator

@nick-stroud nick-stroud commented Jan 14, 2023

Adds a module that creates a Google Cloud Storage bucket.

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@heyealex heyealex assigned nick-stroud and unassigned heyealex Jan 18, 2023
@nick-stroud nick-stroud force-pushed the gcs_bucket_module branch 2 times, most recently from 67b7bce to 228b10f Compare January 18, 2023 23:23
Copy link
Contributor

@heyealex heyealex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for making the changes!

I still have one comment open, feel free to close it if you don't think the update is needed.

@heyealex heyealex assigned nick-stroud and unassigned heyealex Jan 19, 2023
@nick-stroud nick-stroud merged commit 58ebbee into GoogleCloudPlatform:develop Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants