Add validation logic for references to outputs from prior modules #840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the validation logic for references to outputs from modules in earlier deployment groups. It does not yet add full support for these references; this will require further PRs to implement. However, it puts into place the validation logic such that these "intergroup references" are rejected for cases we never intend to support. For example, intergroup references are rejected when:
There is an implicit change here that allows the user to use references with explicit groups even in the "intragroup reference" case. The behavior of these references is identical to the status quo (
module_id.output_name
). I believe it would be more complicated to enforce and communicate "implicitness" requirements for intragroup references, so it is better to allow them.With this PR, unit test coverage for the package improves from 84.9% to 85.3%.
Submission Checklist
pre-commit install
)make tests
)