Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for slurm-gcp 5.4.0 #843

Merged
merged 5 commits into from
Jan 20, 2023

Conversation

SkylerMalinowski
Copy link
Contributor

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@google-cla
Copy link

google-cla bot commented Jan 18, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cboneti cboneti self-requested a review January 19, 2023 04:33
@cboneti cboneti self-assigned this Jan 19, 2023
@cboneti
Copy link
Member

cboneti commented Jan 19, 2023

/gcbrun

@cboneti cboneti requested a review from heyealex January 19, 2023 04:45
Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good to me, assuming the tests pass (still running as I write this).

@heyealex I would love if you could take a look at the changes in community/modules/scheduler/schedmd-slurm-gcp-v5-hybrid/ main.tf and variables.tf. Thanks.

@cboneti cboneti assigned heyealex and unassigned cboneti Jan 19, 2023
Copy link
Contributor

@heyealex heyealex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a test with our GCP demo (documented here) and it all worked as expected.

I also looked over the code and everything looks correct to me. Thank you!

@heyealex heyealex merged commit b0b63e9 into GoogleCloudPlatform:develop Jan 20, 2023
@cboneti cboneti mentioned this pull request Jan 31, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants