-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for slurm-gcp 5.4.0 #843
Updates for slurm-gcp 5.4.0 #843
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good to me, assuming the tests pass (still running as I write this).
@heyealex I would love if you could take a look at the changes in community/modules/scheduler/schedmd-slurm-gcp-v5-hybrid/ main.tf and variables.tf. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran a test with our GCP demo (documented here) and it all worked as expected.
I also looked over the code and everything looks correct to me. Thank you!
Submission Checklist
pre-commit install
)make tests
)