Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fluent Tutorial to Develop #855

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Add Fluent Tutorial to Develop #855

merged 5 commits into from
Jan 25, 2023

Conversation

jrossthomson
Copy link
Contributor

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@heyealex heyealex self-requested a review January 24, 2023 20:46
@heyealex heyealex self-assigned this Jan 24, 2023
@heyealex
Copy link
Contributor

/gcbrun

heyealex
heyealex suggested changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@heyealex heyealex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this Ross!

The pre-commit check flagged some a few lines in your yaml, I added comments to point out what needs to be updated to get past the check. I also included a couple minor change requests.

community/examples/fluent-tutorial.yaml Outdated Show resolved Hide resolved
community/examples/fluent-tutorial.yaml Outdated Show resolved Hide resolved
community/examples/fluent-tutorial.yaml Outdated Show resolved Hide resolved
community/examples/fluent-tutorial.yaml Outdated Show resolved Hide resolved
community/examples/fluent-tutorial.yaml Outdated Show resolved Hide resolved
@heyealex heyealex assigned jrossthomson and unassigned heyealex Jan 24, 2023
@jrossthomson jrossthomson removed their assignment Jan 24, 2023
@jrossthomson
Copy link
Contributor Author

@heyealex PTAL.

@heyealex
Copy link
Contributor

/gcbrun

heyealex
heyealex reviewed Jan 24, 2023
View reviewed changes
Copy link
Contributor

@heyealex heyealex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! One more minor complaint from pre-commit and one more source that needs to be updated.

examples/README.md Outdated Show resolved Hide resolved
community/examples/fluent-tutorial.yaml Outdated Show resolved Hide resolved
@jrossthomson
Copy link
Contributor Author

/gcbrun

@jrossthomson
Copy link
Contributor Author

@heyealex PTAL

@cboneti
Copy link
Member

cboneti commented Jan 25, 2023

/gcbrun

@cboneti cboneti changed the base branch from develop to release-candidate January 25, 2023 17:45
@cboneti cboneti assigned heyealex and unassigned jrossthomson Jan 25, 2023
@heyealex heyealex merged commit ec1231a into GoogleCloudPlatform:release-candidate Jan 25, 2023
@jrossthomson jrossthomson deleted the develop branch August 18, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyealex heyealex heyealex approved these changes

Assignees

@heyealex heyealex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrossthomson @heyealex @cboneti