Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Makefile so coverage fails when tests fail. #89

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Fix Makefile so coverage fails when tests fail. #89

merged 2 commits into from
Jan 27, 2022

Conversation

cboneti
Copy link
Member

@cboneti cboneti commented Jan 26, 2022

Submission Checklist:

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

@cboneti cboneti requested a review from heyealex January 26, 2022 23:42
@cboneti cboneti self-assigned this Jan 26, 2022
@cboneti cboneti merged commit 5245cd4 into GoogleCloudPlatform:develop Jan 27, 2022
@cboneti cboneti deleted the fix-coverage branch January 27, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyealex heyealex heyealex approved these changes

Assignees

@cboneti cboneti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cboneti @heyealex