Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform to Terraform best practices #9

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Conform to Terraform best practices #9

merged 2 commits into from
Oct 20, 2021

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Oct 18, 2021

1. Configure both google and google-beta providers
2. Ensure that google and google-beta providers have version constraints.
3. Ensure that terraform client has minimum version enforced (choose
   value presently selected by Cloud Foundation Toolkit)
4. Configure each provider with a default zone; the README for generating YAML
   describes zone as an input variable for all modules.
5. Conform to Terraform standard module structure by creating empty
   outputs.tf file
6. Use best practice # instead of // for single-line comment
7. Conform to snake_case Terraform naming convention

@tpdownes tpdownes marked this pull request as draft October 18, 2021 21:12
@tpdownes tpdownes marked this pull request as ready for review October 18, 2021 21:27
Copy link
Contributor

@heyealex heyealex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had a couple minor questions/comments.

examples/omnia-cluster-simple.yaml Show resolved Hide resolved
pkg/reswriter/versions.tf.tmpl Show resolved Hide resolved
pkg/reswriter/main.tf.tmpl Outdated Show resolved Hide resolved
Copy link
Contributor

@heyealex heyealex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info and clarifications!

1. Configure both google and google-beta providers
2. Ensure that google and google-beta providers have version constraints.
3. Ensure that terraform client has minimum version enforced (choose
   value presently selected by Cloud Foundation Toolkit)
4. Configure each provider with a default zone; the README for generating YAML
   describes zone as an input variable for all modules.
5. Conform to Terraform standard module structure by creating empty
   outputs.tf file
@tpdownes tpdownes merged commit f43fc60 into GoogleCloudPlatform:develop Oct 20, 2021
@tpdownes tpdownes deleted the provider_best_practices branch October 20, 2021 17:02
nick-stroud pushed a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants