Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partition outputs #97

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Partition outputs #97

merged 2 commits into from
Feb 3, 2022

Conversation

heyealex
Copy link
Contributor

@heyealex heyealex commented Feb 2, 2022

Added all partition parameters as variables in the compute partition resource including:

  • resource
  • regional_capacity
  • regional_policy
  • instance_template

This PR also updates the default for cpu_platform to null to keep it inline with the default in slurm-gpc

Submission Checklist:

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

@heyealex heyealex requested a review from cboneti February 2, 2022 22:25
@heyealex heyealex merged commit 09c372f into GoogleCloudPlatform:develop Feb 3, 2022
@heyealex heyealex deleted the partition-outputs branch February 3, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cboneti cboneti cboneti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heyealex @cboneti