Upgrade Fluentd to v1.2.5 and bump gem version to v0.7.0. #240
Conversation
|
Pending for soak test result. |
qingling128
force-pushed
the
lingshi-upgrade
branch
2 times, most recently
from
e769283 to
c88db9e
Compare
| @@ -19,7 +19,7 @@ eos | |||
| gem.test_files = gem.files.grep(/^(test)/) | |||
| gem.require_paths = ['lib'] | |||
|
|
|||
| gem.add_runtime_dependency 'fluentd', '~> 0.10' | |||
| gem.add_runtime_dependency 'fluentd', '~> 1.2', '>= 1.2.5' | |||
There was a problem hiding this comment.
Alternative
gem.add_runtime_dependency 'fluentd', '>= 0.10', '< 2'
If we'd like to have some backward compatibility for users who have Fluentd v1.2 incompatible configuration. But that means they could be exposed to the memory issue.`
There was a problem hiding this comment.
I think that's fine. We'd stop supporting earlier versions of fluentd after the version bump.
|
Soak test passed for Fluentd v1.2.5.rc1. Kicking off this PR so that we can build a full package. Will run soak test against the new package again. |
qingling128
changed the title
| @@ -19,7 +19,7 @@ eos | |||
| gem.test_files = gem.files.grep(/^(test)/) | |||
| gem.require_paths = ['lib'] | |||
|
|
|||
| gem.add_runtime_dependency 'fluentd', '~> 0.10' | |||
| gem.add_runtime_dependency 'fluentd', '~> 1.2', '>= 1.2.5' | |||
There was a problem hiding this comment.
I think that's fine. We'd stop supporting earlier versions of fluentd after the version bump.
| @@ -228,7 +228,7 @@ module InternalConstants | |||
| Fluent::Plugin.register_output('google_cloud', self) | |||
|
|
|||
| PLUGIN_NAME = 'Fluentd Google Cloud Logging plugin'.freeze | |||
| PLUGIN_VERSION = '0.6.23'.freeze | |||
| PLUGIN_VERSION = '0.7.0'.freeze | |||
There was a problem hiding this comment.
Great. I will rebase when that's merged.
fluent-plugin-google-cloud.gemspec
Outdated
| @@ -10,7 +10,7 @@ eos | |||
| gem.homepage = | |||
| 'https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud' | |||
| gem.license = 'Apache-2.0' | |||
| gem.version = '0.6.23' | |||
| gem.version = '0.7.0' | |||
There was a problem hiding this comment.
We have a bunch of pending changes. Do we want to wait until those are in before bumping the version?
Alternatively, should we bump the version off a clean release (so that pulling in fluentd 1.2 is the only change)? This would mean releasing 0.6.24 first.
There was a problem hiding this comment.
Yes, that makes perfect sense. I think we are releasing at v0.6.24 next week. This will definitely wait till after that.
qingling128
force-pushed
the
lingshi-upgrade
branch
from
c88db9e to
1e1a9b2
Compare
|
Rebased off master after #245 was merged to master. PTAL |
qingling128
force-pushed
the
lingshi-upgrade
branch
2 times, most recently
from
1902e11 to
299181f
Compare
|
Rebased off master again. |
qingling128
force-pushed
the
lingshi-upgrade
branch
from
299181f to
d5b9bf8
Compare
qingling128
force-pushed
the
lingshi-upgrade
branch
from
d5b9bf8 to
595560b
Compare
…)" This reverts commit 906df5e.
Upgrade Fluentd to v1.2.5 (latest as of Aug 24, 2018) to apply this fix fluent/fluentd#1941.
Fixes #251.