memorystore: add Dockerfile for Cloud Run deployment #1538
Conversation
googlebot
added
the
cla: yes
ghost
changed the title
| # Use the official Golang image to create a build artifact. | ||
| # This is based on Debian and sets the GOPATH to /go. | ||
| # https://hub.docker.com/_/golang | ||
| FROM golang:1.13 as builder |
There was a problem hiding this comment.
Should we use 1.13 or 1.14? If this is only for Cloud Run, it seems like we should use 1.14?
There was a problem hiding this comment.
The current "canonical" Dockerfile base image is golang:1.13-buster, though #1541 proposed to update that to 1.14. I'm fine rolling that forward. More significantly, this Dockerfile is a copy of an earlier version of the template used in Cloud Run, it would be best to update this from the Cloud Run Pub/Sub sample Dockerfile
There was a problem hiding this comment.
I've updated the Dockerfile based on the Cloud Run Pub/Sub sample, thanks
| # Use the official Golang image to create a build artifact. | ||
| # This is based on Debian and sets the GOPATH to /go. | ||
| # https://hub.docker.com/_/golang | ||
| FROM golang:1.13 as builder |
There was a problem hiding this comment.
The current "canonical" Dockerfile base image is golang:1.13-buster, though #1541 proposed to update that to 1.14. I'm fine rolling that forward. More significantly, this Dockerfile is a copy of an earlier version of the template used in Cloud Run, it would be best to update this from the Cloud Run Pub/Sub sample Dockerfile
memorystore/redis/go.mod
Outdated
|
|
||
| go 1.13 | ||
|
|
||
| require github.com/gomodule/redigo v2.0.0+incompatible |
There was a problem hiding this comment.
Looks like the redigo community has been spinning on what to do about this incompatible flag, possibly 2.0 is meant to be ignored.
Resolution in gomodule/redigo#366 or gomodule/redigo#440 are not clearly documented.
I wonder if it's since been fixed, and re-generating the go.mod and go.sum would help?
There was a problem hiding this comment.
Looks like it's fixed - I regenerated go.mod and go.sum
tbpg
added
the
automerge
tbpg
changed the title
|
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
tbpg
added
kokoro:run
kokoro-team
removed
the
kokoro:run
tbpg
removed
the
automerge
I'm working on a tutorial for connecting to Memorystore from Cloud Run via Serverless VPC Access. The existing sample app still works, we just need a Dockerfile to deploy it. I'm also adding back
go.modandgo.sumin the proper location, and including a.gcloudignore.