Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated method from bigtable change-streams sample #8438

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

kweinmeister
Copy link
Contributor

@kweinmeister kweinmeister commented Jul 17, 2023

The withHeartbeatDuration() method was removed in the 2.49.0 Beam release, causing this sample to no longer compile with 2.49.0. The sample will now use the default value of 5 seconds.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: bigtable Issues related to the Bigtable API. labels Jul 17, 2023
@kweinmeister kweinmeister marked this pull request as ready for review July 17, 2023 20:25
@kweinmeister kweinmeister requested review from a team and yoshi-approver as code owners July 17, 2023 20:25
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@averikitsch averikitsch merged commit 2cf6dbb into main Jul 17, 2023
@averikitsch averikitsch deleted the change-streams branch July 17, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants