Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utils functions for RelativeResourceNameWithVersion #78

Conversation

spencerhance
Copy link
Member

This func generates a string very similar to a SelfLink but without including the "googleapis.com" endpoint."

This func generates a string very similar to a SelfLink but without including the "googleapis.com" endpoint."
@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: spencerhance
Once this PR has been reviewed and has the lgtm label, please assign bowei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spencerhance
Copy link
Member Author

/assign @bowei

@bowei
Copy link
Member

bowei commented Feb 28, 2023

Let's discuss -- how are we going to use the new function? Don't we need to make the http://googleapis.com... configurable for all instances?

@bowei
Copy link
Member

bowei commented Feb 28, 2023

/hold

@spencerhance
Copy link
Member Author

Closing in favor of #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants