fix: Incorrect value of clientTLSPolicy from ComputeBackendService

[gemmahou]

Change description

Fixes b/374166656

Tests you have done

Resource created successfully:

kubectl describe ComputeBackendService computebackendservice-yuhou1025
Spec:
  Load Balancing Scheme:  INTERNAL_SELF_MANAGED
  Location:               global
  Resource ID:            computebackendservice-yuhou1025
  Security Settings:
    Client TLS Policy Ref:
      Name:  clienttlspolicy-yuhou1025
    Subject Alt Names:
      spiffe://junk.svc.id.goog/ns/test/sa/frontend
  Timeout Sec:  10
Status:
  Conditions:
    Last Transition Time:  2024-10-25T19:18:09Z
    Message:               The resource is up to date
    Reason:                UpToDate
    Status:                True
    Type:                  Ready
  Creation Timestamp:      2024-10-25T12:03:28.186-07:00
  Fingerprint:             KkS0AHjQtyc=
  Generated Id:            2810711594725955000
  Observed Generation:     2
  Self Link:               https://www.googleapis.com/compute/v1/projects/cnrm-yuhou/global/backendServices/computebackendservice-yuhou1025
Events:
  Type     Reason              Age                  From                              Message
  ----     ------              ----                 ----                              -------
  Warning  DependencyNotReady  17m                  computebackendservice-controller  reference NetworkSecurityClientTLSPolicy default/clienttlspolicy-yuhou1025 is not ready
  Normal   Updating            2m40s (x4 over 17m)  computebackendservice-controller  Update in progress
  Normal   UpToDate            2m19s (x4 over 16m)  computebackendservice-controller  The resource is up to date

Dynamic test passed(after skipping testNoChangeAfterCreate):

--- PASS: TestCreateNoChangeUpdateDelete (0.17s)
    --- PASS: TestCreateNoChangeUpdateDelete/compute (0.00s)
        --- PASS: TestCreateNoChangeUpdateDelete/compute/basic-globalcomputebackendservicesecuritysettings (154.81s)
PASS

• Run make ready-pr to ensure this PR is ready for review.
• Perform necessary E2E testing for changed resources.

[maqiuyujoyce]

Thank you for the fix, @gemmahou ! Mostly LGTM with a couple of comments.

[maqiuyujoyce]

Can we make this field unreadable so that it'll always use the value specified in the CR as the live state for comparison?

Not a blocker for this PR though.

[cheftako]

Might be good to make this sort of description more of a standard. Seems like a huge improvement. Worth noting that for this resource it seems like location always has to be "global".

[gemmahou]

ClientTlsPolicy does support other locations(API doc).

If a user incorrectly configures a regional policy, the request should be sent to the API as is and let the API to handle the error. We may not want to convert the regional policy to a global policy on our side(?). In rare cases, there might be a global resource with the same name, and this could lead to confusion.

[maqiuyujoyce]

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maqiuyujoyce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maqiuyujoyce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment