Generate set-unset golden output for gkehubfeaturemembership #3163
+2,576
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @acpana |
ziyue-101
force-pushed
the
add-scenario-gkehub
branch
from
d4c4908
to
ea86016
Compare
|
Thanks for this 🙏🏼 /lgtm cc @maqiuyujoyce would you mind approving too? This for us to capture the state currently w the TF controller. Once we cut over to the direct controller we may update these files. |
|
/assign @maqiuyujoyce |
tests/e2e/testdata/scenarios/fields/gkehubfeaturemembership/set_unset/script.yaml
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acpana, maqiuyujoyce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ziyue-101
force-pushed
the
add-scenario-gkehub
branch
from
ea86016
to
a929d2f
Compare
|
/lgtm |
google-oss-prow
bot
merged commit b113a9a
into
GoogleCloudPlatform:master
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
#2027 got closed unexpectedly
Creating a new PR
Tests you have done
make ready-prto ensure this PR is ready for review.