Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ASM to v1.13 #369

Merged
merged 15 commits into from
Jul 7, 2022
Merged

Upgrade ASM to v1.13 #369

merged 15 commits into from
Jul 7, 2022

Conversation

gkcalat
Copy link
Contributor

@gkcalat gkcalat commented Jul 1, 2022

Upgrading ASM to 1.13:

  • Changed installation process to use asmcli tool instead of install_asm tool
  • Using istio-1-11 from Manifests as it is currently sufficient. Planning to switch to istio-1-14 once ASM v 1.14 is released
  • Updated healthCheck configuration:
    • New requestPath: /healthz
    • New port: "http2"

Tested run on end-2-end MNIST example

@google-oss-prow google-oss-prow bot requested a review from zijianjoy July 1, 2022 17:29
@gkcalat
Copy link
Contributor Author

gkcalat commented Jul 1, 2022

/assign @zijianjoy

@gkcalat
Copy link
Contributor Author

gkcalat commented Jul 1, 2022

Closes #366

@gkcalat gkcalat changed the title Asm113 Upgrade ASM to v1.13 Jul 1, 2022
zijianjoy
zijianjoy reviewed Jul 1, 2022
View reviewed changes
kubeflow/asm/Makefile Outdated Show resolved Hide resolved
kubeflow/asm/Makefile Outdated Show resolved Hide resolved
kubeflow/asm/Makefile Outdated Show resolved Hide resolved
kubeflow/common/iap-ingress/base/config-map.yaml Outdated Show resolved Hide resolved
kubeflow/common/iap-ingress/base/config-map.yaml Outdated Show resolved Hide resolved
kubeflow/pull-upstream.sh Show resolved Hide resolved
zijianjoy
zijianjoy reviewed Jul 6, 2022
View reviewed changes
kubeflow/asm/Makefile Outdated Show resolved Hide resolved
kubeflow/asm/deprecated/README.md Show resolved Hide resolved
zijianjoy
zijianjoy reviewed Jul 7, 2022
View reviewed changes
kubeflow/asm/deprecated/README.md Outdated Show resolved Hide resolved
kubeflow/asm/README.md Outdated Show resolved Hide resolved
@gkcalat gkcalat requested a review from zijianjoy July 7, 2022 05:17
@zijianjoy
Copy link
Collaborator

/lgtm
/approve

Thank you so much Ablai, that is great work upgrading ASM version!

@google-oss-prow google-oss-prow bot added the lgtm label Jul 7, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gkcalat, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7411b18 into GoogleCloudPlatform:master Jul 7, 2022
@gkcalat gkcalat deleted the asm113 branch July 7, 2022 15:46
gkcalat added a commit that referenced this pull request Jul 8, 2022
@gkcalat
Upgrade ASM to v1.13 (#369)
bdfb0d5 
* Upgrade ASM from v1.10 to v1.13

* Fix install-asm role name

* Change to istio-1-11 folder in kubeflow/manifests. ASM will install istio v 1.13 though

* Fix comments

* closes #366

* Revert conbfig-map and include GitOps friendly RequestAuthetication

* Remove legacy install_asm. Force hydrate before installation of ASM

* Split install-asm and hydrate rules. Update README.

* Downgrade ASM to 1.13.2

* Add a note about install_asm and asmcli

* Add a note about install_asm and asmcli # 2

* Improve readability of ASM upgrade instructions

* Fix typos, improve wording while preserving the old instruction as they are.

* Emphasize 'legacy' in the depraceted instructions, fix consistent formatting for file names in new instructions.

Co-authored-by: Ablai Akhazhanov <ablai@google.com>
@pablofiumara
Copy link

@gkcalat @zijianjoy I am a GCP client using this version (asm-1132-5) and getting error 502. I am using latest Kubeflow version on GCP (1.5.1). Every pod is running. This error seems to be different than what happened here: #371

How can I solve this? Thanks in advance

@zijianjoy
Copy link
Collaborator

@pablofiumara We are working on making the new Kubeflow release v1.6. Upgrading ASM itself might not be enough because you also need to upgrade istio version to 1.11+.

Also feel free to share your error message in a new GitHub issue.

@pablofiumara pablofiumara mentioned this pull request Aug 12, 2022
Closed
@pablofiumara
Copy link

@zijianjoy Thank you. Created new Github issue #379

@gkcalat gkcalat mentioned this pull request Mar 12, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@zijianjoy zijianjoy

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkcalat @zijianjoy @pablofiumara