Skip to content

Commit

Permalink
Add upgrade note for IoT registry event_notification_configs (#2390) (#…
Browse files Browse the repository at this point in the history
…2651)

Merged PR #2651.
  • Loading branch information
emilymye authored and modular-magician committed Nov 12, 2019
1 parent 03fc72c commit 7a0f4be
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 2 deletions.
2 changes: 1 addition & 1 deletion build/terraform
2 changes: 1 addition & 1 deletion build/terraform-beta
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ so Terraform knows to manage them.
- [Resource: `google_project_service`](#resource-google_project_service)
- [Resource: `google_project_services`](#resource-google_project_services)
- [Resource: `google_pubsub_subscription`](#resource-google_pubsub_subscription)
- [Resource: `google_cloudiot_registry`](#resource-google_cloudiot_registry)

<!-- /TOC -->

Expand Down Expand Up @@ -378,3 +379,40 @@ resource "google_project_service" "project_cloudresourcemanager" {

`name` previously could have been specified by a long name (e.g. `projects/my-project/subscriptions/my-subscription`)
or a shortname (e.g. `my-subscription`). `name` now must be the shortname.


## Resource: `google_cloudiot_registry`

### Replace singular event notification config field with plural `event_notification_configs`

Use the plural field `event_notification_configs` instead of
`event_notification_config`, which has now been removed.
Since the Cloud IoT API now accept multiple event notification configs for a
registry, the singular field no longer exists on the API resource and has been
removed from Terraform to prevent conflicts.


#### Old Config

```hcl
resource "google_cloudiot_registry" "myregistry" {
name = "%s"
event_notification_config {
pubsub_topic_name = "${google_pubsub_topic.event-topic.id}"
}
}
```

#### New Config

```hcl
resource "google_cloudiot_registry" "myregistry" {
name = "%s"
event_notification_configs {
pubsub_topic_name = "${google_pubsub_topic.event-topic.id}"
}
}
```

0 comments on commit 7a0f4be

Please sign in to comment.