Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Promote metric settings in compute region autoscaler to GA" #10095

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Revert "Promote metric settings in compute region autoscaler to GA" #10095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mmv1/products/compute/RegionAutoscaler.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ properties:
Defines operating mode for this policy.
- !ruby/object:Api::Type::NestedObject
name: 'scaleDownControl'
min_version: beta
description: |
Defines scale down controls to reduce the risk of response latency
and outages due to abrupt scale-in events
Expand Down Expand Up @@ -264,6 +265,7 @@ properties:
required: true
- !ruby/object:Api::Type::Double
name: 'singleInstanceAssignment'
min_version: beta
description: |
If scaling is based on a per-group metric value that represents the
total amount of work to be done or resource usage, set this value to
Expand Down Expand Up @@ -339,6 +341,7 @@ properties:
(if you are using gce_instance resource type). If multiple
TimeSeries are returned upon the query execution, the autoscaler
will sum their respective values to obtain its scaling value.
min_version: beta
- !ruby/object:Api::Type::NestedObject
name: 'loadBalancingUtilization'
description: |
Expand Down
4 changes: 4 additions & 0 deletions mmv1/third_party/terraform/services/compute/resource_compute_region_autoscaler_test.go.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,12 +217,14 @@ resource "google_compute_region_autoscaler" "foobar" {
target = 0.5
predictive_method = "OPTIMIZE_AVAILABILITY"
}
<% unless version == 'ga' -%>
scale_down_control {
max_scaled_down_replicas {
percent = 80
}
time_window_sec = 300
}
<% end -%>
}
}
`, autoscalerName)
Expand Down Expand Up @@ -267,12 +269,14 @@ resource "google_compute_region_autoscaler" "foobar" {
cpu_utilization {
target = 0.5
}
<% unless version == 'ga' -%>
scale_down_control {
max_scaled_down_replicas {
percent = 80
}
time_window_sec = 300
}
<% end -%>
scaling_schedules {
name = "every-weekday-morning"
description = "Increase to 2 every weekday at 7AM for 6 hours."
Expand Down
Loading