Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for allPorts to (regional) Forwarding Rule for ILB #1126

Merged
merged 4 commits into from
Jan 2, 2019
Merged

Add support for allPorts to (regional) Forwarding Rule for ILB #1126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc9dee1
Add support for allPorts at Beta to ForwardingRule.
rileykarson Jan 2, 2019
f2a3b9d
Add comment about docs disparity.
rileykarson Jan 2, 2019
0c9773d
Emit correct values for tests in GA
rileykarson Jan 2, 2019
0029baa
Update tracked submodules -> HEAD on Wed Jan 2 18:01:38 UTC 2019
modular-magician Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/terraform
Open in desktop
Submodule terraform updated from d17b31 to e9cb61
2 changes: 1 addition & 1 deletion build/terraform-beta
Open in desktop
Submodule terraform-beta updated from 115c62 to 8684ac
9 changes: 9 additions & 0 deletions products/compute/api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,6 +1009,15 @@ objects:
update_url: 'projects/{{project}}/regions/{{region}}/forwardingRules/{{name}}/setLabels'
update_verb: :POST
min_version: beta
# While this field doesn't appear in the resource definition in the docs,
# it's present in Get and Insert, and the resource has no Update/Patch call.
- !ruby/object:Api::Type::Boolean
name: 'allPorts'
description: |
When the load balancing scheme is INTERNAL and protocol is TCP/UDP, omit
`port`/`port_range` and specify this field as `true` to allow packets addressed
to any ports to be forwarded to the backends configured with this forwarding rule.
min_version: beta
- !ruby/object:Api::Type::Enum
name: 'networkTier'
description: |
Expand Down
4 changes: 4 additions & 0 deletions third_party/terraform/tests/resource_compute_forwarding_rule_test.go.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,11 @@ resource "google_compute_forwarding_rule" "foobar" {
name = "%s"
load_balancing_scheme = "INTERNAL"
backend_service = "${google_compute_region_backend_service.foobar-bs.self_link}"
<% unless version == 'ga' -%>
all_ports = true
<% else -%>
ports = ["80"]
<% end -%>
network = "${google_compute_network.foobar.name}"
subnetwork = "%s"
}
Expand Down