Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update mask support to uptimeChecks #1140

Merged

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Jan 3, 2019

Add update mask support for uptimeChecks

Fixes the regression bug introduced in #1129


[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#305
depends: hashicorp/terraform-provider-google#2786

@chrisst chrisst force-pushed the uptime-check-force-2 branch from cfd838f to a126f46 Compare January 3, 2019 01:01
@chrisst chrisst changed the title Allow duration to be updatable and force new [WIP] Allow duration to be updatable and force new Jan 3, 2019
@nat-henderson
Copy link
Contributor

Ping me when you want a review! :)

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 1a4cb82) have been included in your existing downstream PRs.

@chrisst chrisst changed the title [WIP] Allow duration to be updatable and force new Add update mask support to uptimeChecks Jan 3, 2019
@chrisst
Copy link
Contributor Author

chrisst commented Jan 3, 2019

ready!

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that's easy.

@modular-magician modular-magician merged commit fe9da5f into GoogleCloudPlatform:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants