adds support for the Dataproc on GDC SparkApplication resource

[JerryLeiDing]

This PR adds support for the Dataproc on GDC SparkApplication resource to the provider.

`google_dataproc_gdc_spark_application`

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

[JerryLeiDing]

@zli82016 gentle ping on this PR

[zli82016]

Also, can you add update tests for the mutable fields by following the doc ? Thanks.

[zli82016]

Is there a Github issue for this PR? If yes, you can link the Github issue in the description section of this PR.

[JerryLeiDing]

Also, can you add update tests for the mutable fields by following the doc ? Thanks.

The resource does not support update currently.

[zli82016]

Also, can you add update tests for the mutable fields by following the doc ? Thanks.

The resource does not support update currently.

In this case, can you add immutable: true to the resource?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2357 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 2357 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 488 insertions(+))
Open in Cloud Shell: Diff ( 20 files changed, 596 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_gdc_spark_application (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_gdc_spark_application" "primary" {
  dependency_images = # value needed
  requested_state   = # value needed
  spark_sql_application_config {
    query_file_uri = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 9
Passed tests: 4
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages

• dataprocgdc

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationBasicExample
• TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationExample
• TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationPysparkExample
• TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationSparkrExample
• TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationSparksqlExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationExample [Debug log]
TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationPysparkExample [Debug log]
TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationSparkrExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationBasicExample [Error message] [Debug log]
TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationSparksqlExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[JerryLeiDing]

Also, can you add update tests for the mutable fields by following the doc ? Thanks.

The resource does not support update currently.

In this case, can you add immutable: true to the resource?

Done

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2318 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 2318 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 478 insertions(+))
Open in Cloud Shell: Diff ( 20 files changed, 597 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_gdc_spark_application (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_gdc_spark_application" "primary" {
  spark_sql_application_config {
    query_file_uri = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 9
Passed tests: 6
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• dataprocgdc

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationBasicExample
• TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationPysparkExample
• TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationSparksqlExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationBasicExample [Debug log]
TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationPysparkExample [Debug log]
TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationSparksqlExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[JerryLeiDing]

@zli82016 are there any other changes you would like to see on this PR?

[zli82016]

Can you please remove these lines, as the resource is immutable?

[JerryLeiDing]

Done

[zli82016]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2318 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 6 files changed, 2318 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 478 insertions(+)) Open in Cloud Shell: Diff ( 20 files changed, 597 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_gdc_spark_application (5 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_gdc_spark_application" "primary" {
  spark_sql_application_config {
    query_file_uri = # value needed
  }
}

Can you add the test for this field query_file_uri? Thanks.

[JerryLeiDing]

Can you add the test for this field query_file_uri? Thanks.

Done

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2393 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 2393 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 478 insertions(+))
Open in Cloud Shell: Diff ( 24 files changed, 713 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_gdc_spark_application (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_gdc_spark_application" "primary" {
  spark_sql_application_config {
    query_file_uri = # value needed
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2393 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 2393 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 478 insertions(+))
Open in Cloud Shell: Diff ( 24 files changed, 713 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_gdc_spark_application (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_gdc_spark_application" "primary" {
  spark_sql_application_config {
    query_file_uri = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• dataprocgdc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationSparksqlQueryFileExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationSparksqlQueryFileExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• dataprocgdc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationSparksqlQueryFileExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationSparksqlQueryFileExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2393 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 2393 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 478 insertions(+))
Open in Cloud Shell: Diff ( 24 files changed, 713 insertions(+))

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• dataprocgdc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationSparksqlQueryFileExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataprocGdcSparkApplication_dataprocgdcSparkapplicationSparksqlQueryFileExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[zli82016]

LGTM