Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all fields for monitored resource to force recreation #1461

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Mar 1, 2019

fixes hashicorp/terraform-provider-google#3132


[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 4e5db5a.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#485
depends: hashicorp/terraform-provider-google#3160

@@ -39,7 +40,49 @@ func TestAccMonitoringUptimeCheckConfig_update(t *testing.T) {
})
}

func testAccMonitoringUptimeCheckConfig_update(path, project, pwd string) string {
// The second update should force a recreation of the uptime check because 'monitored_resource' isn't
// updatable in place
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still don't have a way to test force-recreates, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly no :(

chrisst and others added 3 commits March 14, 2019 17:11
@modular-magician modular-magician force-pushed the monitoring-config-check-updates branch from 4e5db5a to c56b38f Compare March 14, 2019 17:11
@modular-magician modular-magician merged commit c457de4 into GoogleCloudPlatform:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed updates to google_monitoring_uptime_check_config
5 participants