Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add machine_type to dataflow_job #1862

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Add machine_type to dataflow_job #1862

merged 1 commit into from
Jun 3, 2019

Conversation

tysen
Copy link

@tysen tysen commented May 31, 2019

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@tysen tysen requested a review from danawillow May 31, 2019 19:28
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 913f76a.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#793
depends: hashicorp/terraform-provider-google#3761

@tysen tysen requested review from rileykarson and removed request for danawillow June 3, 2019 21:48
rileykarson
rileykarson approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Weird that it doesn't look like the machine_type value is recoverable in the API.

@modular-magician modular-magician merged commit 95153df into GoogleCloudPlatform:master Jun 3, 2019
@tysen tysen mentioned this pull request Jun 5, 2019
Closed
@tysen tysen deleted the machine-type branch July 24, 2019 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tysen @modular-magician @rileykarson @googlebot