Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for renamed services in google_project_service* resources. #2424

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Oct 3, 2019

Fixes hashicorp/terraform-provider-google#4590

I've handled every case I could think up, and captured most of the ones I can in a test. Locally, I've tested this with the fake old API compute2.googleapis.com and it's worked as expected.

If you can think of an out-there case, please try it 🙂

Release Note Template for Downstream PRs (will be copied)

note: `google_project_services` users of provider versions prior to `2.17.0` should update, as past versions of the provider will not handle an upcoming rename of `bigquery-json.googleapis.com` to `bigquery.googleapis.com` well. See https://github.com/terraform-providers/terraform-provider-google/issues/4590 for details.
projectservice: added mitigations for bigquery-json to bigquery rename in project service resources.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 03b2121.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1234
depends: GoogleCloudPlatform/terraform-google-conversion#222
depends: hashicorp/terraform-provider-google#4616

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this isn't going to break users today or post-rollback - I am only pretty sure it doesn't break users post-flip. Are you sure it doesn't?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b814cb7.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@rileykarson
Copy link
Member Author

I believe so, yeah- or, as much as I can be confident it will without testing the actual change in prod. During development I tested locally by adding "compute2.googleapis.com": "compute.googleapis.com" to renamedServices to simulate a post-flip service and it passed all the cases in TestAccProjectServices_renamedServices + a few more while running interactively.

Additionally, TestAccProjectServices_renamedServices is successful after swapping bigquery-json and bigquery in renamedServices + moving the import step to a place with just bigquery in config (since it's the old value in that case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error enabling bigquery.googleapis.com
4 participants