-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for renamed services in google_project_service* resources. #2424
Add support for renamed services in google_project_service* resources. #2424
Conversation
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in Ansible. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this isn't going to break users today or post-rollback - I am only pretty sure it doesn't break users post-flip. Are you sure it doesn't?
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
I believe so, yeah- or, as much as I can be confident it will without testing the actual change in prod. During development I tested locally by adding Additionally, |
b814cb7
to
0fad473
Compare
Fixes hashicorp/terraform-provider-google#4590
I've handled every case I could think up, and captured most of the ones I can in a test. Locally, I've tested this with the fake old API
compute2.googleapis.com
and it's worked as expected.If you can think of an out-there case, please try it 🙂
Release Note Template for Downstream PRs (will be copied)