Drop pgp_key. #2661
Closed
Drop pgp_key. #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return err | ||
| } | ||
|
|
||
| d.Set("private_key_encrypted", encrypted) |
There was a problem hiding this comment.
Should you remove / deprecate any of these fields also?
3.0.0 diff report as of d12ac55995823d2d79a8100750f4e840d1d8fd3e |
….0. (GoogleCloudPlatform#2352) * cloudbuild build trigger's trigger template should be required in 3.0.0.
* Changing IAM audit config to be authoritative * Remove unused code + test
…tform#2282) * Add validation for scratch disks * Remove source from scratch disk * Use hardcoded image * Add reverse logic
…latform#2461) * Change default id format from {{name}} to self_link_uri
* Update ID fields for various MM-generated resources
…form#2502) * Composer environment and compute attached disk id updates * Add compute instance * Add instance_from_group and instance_group * IGM id * Instance template tests passing * Add new id format to other calls of parseImportId in IGM * Small refactor to memoize var * Refactor, remove parseImportId in IGM
* Fix cloudfunction formatting, migrate RIGM id * Update security policy resource id * Update target pool id format * Add new id for container cluster * Node pool id updates * PR feedback, using parseImportId for container resources * Formatting
* Update datasources * formatting
* Dataproc cluster, job, google project * Update sql ssl cert, database instance ids * Project id comparison include projects/
…leCloudPlatform#2642) * Make master_authorized_networks_config.cidr_blocks Optional in GKE * Add note
update comment
* Add upgrade guide for subnetwork log_config * Add examples for subnet logConfig update * Wording on upgrade guide
* Add misc entries to the upgrade guide * Remove extra space
…rm#2638) * Convert old import formats (using non-/) to use /.
* Add upgrade note for IoT registry event_notification_configs (GoogleCloudPlatform#2390) (GoogleCloudPlatform#2651) Merged PR GoogleCloudPlatform#2651. * sort upgrade guide; change wording in a few places
Update docs to be accurate for 3.0
Remove the pgp_key field, logic, and tests.
paddycarver
force-pushed
the
paddy_drop_pgp_key
branch
from
d12ac55
to
a258940
Compare
Merged
|
Was there a blog post, per the comment? I'd like to socialize this decision to the folks I work with. Right now only have |
|
After some internal discussion, we decided the link you provided was the correct way to document this practice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the pgp_key field, logic, and tests. Fixes hashicorp/terraform-provider-google#4325.
Release Note Template for Downstream PRs (will be copied)