Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make retryConfig computed for Cloud Scheduler jobs #3463

Merged
merged 2 commits into from
May 4, 2020
Merged

Make retryConfig computed for Cloud Scheduler jobs #3463

merged 2 commits into from
May 4, 2020

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented May 1, 2020

Release Note Template for Downstream PRs (will be copied)

cloudscheduler: Fixed permadiff for `google_cloud_scheduler_job.retry_config.*` block when API provides default values

Also rename the handwritten test and GA it - I missed it when I GA'd Job :S

Fixes hashicorp/terraform-provider-google#6204

@emilymye emilymye requested a review from slevenick May 1, 2020 23:16
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 122 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 4 files changed, 27 insertions(+))
TF OiCS: Diff ( 2 files changed, 11 insertions(+))

@emilymye emilymye merged commit 1624658 into GoogleCloudPlatform:master May 4, 2020
This was referenced May 4, 2020
Merged
Merged
Merged
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@emilymye
Make retryConfig computed for Cloud Scheduler jobs (GoogleCloudPlatfo…
023b5ba 
…rm#3463)

* make fields in job retry config computed

* add tests with retry config, remove beta gates for test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slevenick slevenick slevenick approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_cloud_scheduler_job attribute retry_config does not maintain state
4 participants
@emilymye @modular-magician @slevenick @googlebot