Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate the Cloud IoT Core Device resource #3637

Merged
merged 18 commits into from
Jul 13, 2020
Merged

Auto-generate the Cloud IoT Core Device resource #3637

merged 18 commits into from
Jul 13, 2020

Conversation

ferrarimarco
Copy link
Member

@ferrarimarco ferrarimarco commented Jun 15, 2020

This PR automatically generates the Cloud IoT Core Device terraform resource, and the relevant acceptance tests.

Closes hashicorp/terraform-provider-google#1495.

`google_cloudiot_device`

@ferrarimarco ferrarimarco changed the title Cloud iot devices Auto-generate the Cloud IoT Core Device resource Jun 15, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@ferrarimarco
Copy link
Member Author

Hi @slevenick ! This PR is still a draft. I'll mark it as ready in a couple of days, after I add the relevant acceptance tests. Thanks!

/cc @danawillow who knows that this was coming :)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 1374 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1374 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 288 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120517"

@modular-magician
Copy link
Collaborator

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1524 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1524 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 226 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=121093"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 1602 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1602 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 226 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=121410"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 1608 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1608 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 226 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=121413"

@ferrarimarco ferrarimarco marked this pull request as ready for review June 18, 2020 14:29
@ferrarimarco
Copy link
Member Author

Hi @slevenick !

The PR is ready for your review :)

Thanks.

/cc @danawillow @lepistom @kingman

products/cloudiot/api.yaml Outdated Show resolved Hide resolved
products/cloudiot/api.yaml Show resolved Hide resolved
products/cloudiot/api.yaml Show resolved Hide resolved
products/cloudiot/api.yaml Show resolved Hide resolved
products/cloudiot/terraform.yaml Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rambleraptor, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 1609 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1609 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 226 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=122899"

ferrarimarco and others added 5 commits June 26, 2020 09:37
Co-authored-by: Sam Levenick <slevenick@google.com>
Co-authored-by: Sam Levenick <slevenick@google.com>
Co-authored-by: Sam Levenick <slevenick@google.com>
Co-authored-by: Sam Levenick <slevenick@google.com>
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 1609 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1609 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 226 insertions(+))

2 similar comments
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 1609 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1609 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 226 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 1609 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1609 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 226 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 1610 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1610 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 226 insertions(+))

@ferrarimarco
Copy link
Member Author

Thanks @slevenick ! Replied to your last two comments

@ferrarimarco
Copy link
Member Author

@slevenick back to you! Thanks! :)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 1610 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1610 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 226 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 1612 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1612 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 226 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 1612 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1612 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 226 insertions(+))

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clout IoT: ability to add devices
4 participants