Add scheduleOptions to BigQuery Data Transfer #3895

14kw · 2020-08-22T14:38:05Z

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery: added `schedule_options` field to `google_bigquery_data_transfer_config` resource

fixes hashicorp/terraform-provider-google#4670

modular-magician · 2020-08-22T14:39:14Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

modular-magician · 2020-08-22T14:45:21Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 179 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 179 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 51 insertions(+))

samouss · 2020-10-09T22:34:43Z

👋 Is there any plan to merge this? Thanks!

slevenick · 2020-10-12T16:46:37Z

third_party/terraform/tests/resource_bigquery_data_transfer_config_test.go

@@ -54,17 +57,21 @@ func testAccBigqueryDataTransferConfig_scheduledQuery_basic(t *testing.T) {

 func testAccBigqueryDataTransferConfig_scheduledQuery_update(t *testing.T) {
 	random_suffix := randString(t, 10)
+	first_start_time := time.Now().Add(1 * time.Hour).Format(time.RFC3339)


These seem to in an incorrect format as the tests detect diffs based on them.

For example:

~ schedule_options { disable_auto_scheduling = false ~ end_time = "2020-11-12T17:39:51Z" -> "2020-11-12T09:39:51-08:00" ~ start_time = "2020-10-12T17:39:51Z" -> "2020-10-12T10:39:51-07:00" }

slevenick · 2020-10-12T16:46:54Z

products/bigquerydatatransfer/api.yaml

+            description: |
+              Defines time to stop scheduling transfer runs. A transfer run cannot be 
+              scheduled at or after the end time. The end time can be changed at any 
+              moment. The time when a data transfer can be trigerred manually is not 


Suggested change

moment. The time when a data transfer can be trigerred manually is not

moment. The time when a data transfer can be triggered manually is not

slevenick · 2020-10-12T16:47:04Z

products/bigquerydatatransfer/api.yaml

+              Specifies time to start scheduling transfer runs. The first run will be 
+              scheduled at or after the start time according to a recurrence pattern 
+              defined in the schedule string. The start time can be changed at any 
+              moment. The time when a data transfer can be trigerred manually is not 


Suggested change

moment. The time when a data transfer can be trigerred manually is not

moment. The time when a data transfer can be triggered manually is not

slevenick · 2020-10-12T16:47:35Z

Sorry it took me so long to review this, I must have missed the initial email about it!

google-cla · 2020-10-14T05:50:48Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

modular-magician · 2020-10-14T06:38:06Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 179 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 179 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 51 insertions(+))

samouss · 2020-10-14T07:54:26Z

products/bigquerydatatransfer/api.yaml

+              - schedule_options.0.disable_auto_scheduling
+              - schedule_options.0.start_time
+              - schedule_options.0.end_time
+          - !ruby/object:Api::Type::String


Maybe we should use Time rather than String e.g. !ruby/object:Api::Type::Time

magic-modules/products/sql/api.yaml

Line 143 in 897f457

- !ruby/object:Api::Type::Time

modular-magician · 2020-10-14T10:41:37Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 181 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 181 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 51 insertions(+))

modular-magician · 2020-10-14T11:19:56Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 181 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 181 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 51 insertions(+))

slevenick · 2020-10-14T17:00:56Z

/gcbrun

modular-magician · 2020-10-14T17:09:35Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 181 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 181 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 51 insertions(+))

modular-magician · 2020-10-15T10:43:01Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 181 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 181 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 51 insertions(+))

14kw · 2020-10-15T11:10:15Z

I'm sorry. There were no conflicts, but I thought it would be better to catch up with the master and test, so I did rebase and force push.

slevenick · 2020-10-15T16:09:01Z

/gcbrun

modular-magician · 2020-10-15T16:09:19Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152319"

modular-magician · 2020-10-15T16:17:07Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 181 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 181 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 51 insertions(+))

modular-magician · 2020-10-15T17:19:54Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccProviderMeta_setModuleName|TestAccBigqueryDataTransferConfig You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152330"

samouss · 2020-10-25T11:06:21Z

👋 Is there any changes required to move forward?

slevenick

Thanks for the addition!

google-cla bot added the cla: yes label Aug 22, 2020

modular-magician requested a review from slevenick August 22, 2020 14:39

danawillow mentioned this pull request Oct 9, 2020

Add scheduleOptions to BigQuery Data Transfer. #2507

Closed

slevenick requested changes Oct 12, 2020

View reviewed changes

google-cla bot added cla: no and removed cla: yes labels Oct 14, 2020

14kw force-pushed the feature/support-bigquery-transfer-config-schedule-options branch from c4758bb to 7d9a4d7 Compare October 14, 2020 06:29

google-cla bot added cla: yes and removed cla: no labels Oct 14, 2020

samouss reviewed Oct 14, 2020

View reviewed changes

14kw added 4 commits October 15, 2020 19:25

Add scheduleOptions to BigQuery Data Transfer

93f57eb

Fix typo

cff028f

Update set the timezone to UTC

3382cc9

Update API type to Time

98aae59

14kw force-pushed the feature/support-bigquery-transfer-config-schedule-options branch from f3ce7cd to 98aae59 Compare October 15, 2020 10:34

slevenick self-requested a review October 26, 2020 17:10

slevenick approved these changes Oct 26, 2020

View reviewed changes

slevenick merged commit 06eee7a into GoogleCloudPlatform:master Oct 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add scheduleOptions to BigQuery Data Transfer #3895

Add scheduleOptions to BigQuery Data Transfer #3895

14kw commented Aug 22, 2020

modular-magician commented Aug 22, 2020

modular-magician commented Aug 22, 2020

samouss commented Oct 9, 2020

slevenick Oct 12, 2020

slevenick Oct 12, 2020

slevenick Oct 12, 2020

slevenick commented Oct 12, 2020

google-cla bot commented Oct 14, 2020

modular-magician commented Oct 14, 2020

samouss Oct 14, 2020

modular-magician commented Oct 14, 2020

modular-magician commented Oct 14, 2020

slevenick commented Oct 14, 2020

modular-magician commented Oct 14, 2020

modular-magician commented Oct 15, 2020

14kw commented Oct 15, 2020

slevenick commented Oct 15, 2020

modular-magician commented Oct 15, 2020

modular-magician commented Oct 15, 2020

modular-magician commented Oct 15, 2020

samouss commented Oct 25, 2020

slevenick left a comment

	moment. The time when a data transfer can be trigerred manually is not
	moment. The time when a data transfer can be triggered manually is not

Add scheduleOptions to BigQuery Data Transfer #3895

Add scheduleOptions to BigQuery Data Transfer #3895

Conversation

14kw commented Aug 22, 2020

modular-magician commented Aug 22, 2020

modular-magician commented Aug 22, 2020

Diff report:

samouss commented Oct 9, 2020

slevenick Oct 12, 2020

Choose a reason for hiding this comment

slevenick Oct 12, 2020

Choose a reason for hiding this comment

slevenick Oct 12, 2020

Choose a reason for hiding this comment

slevenick commented Oct 12, 2020

google-cla bot commented Oct 14, 2020

modular-magician commented Oct 14, 2020

Diff report:

samouss Oct 14, 2020

Choose a reason for hiding this comment

modular-magician commented Oct 14, 2020

Diff report:

modular-magician commented Oct 14, 2020

Diff report:

slevenick commented Oct 14, 2020

modular-magician commented Oct 14, 2020

Diff report:

modular-magician commented Oct 15, 2020

Diff report:

14kw commented Oct 15, 2020

slevenick commented Oct 15, 2020

modular-magician commented Oct 15, 2020

modular-magician commented Oct 15, 2020

Diff report:

modular-magician commented Oct 15, 2020

samouss commented Oct 25, 2020

slevenick left a comment

Choose a reason for hiding this comment