-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ingress option to Google Cloud Functions #3977
Add new ingress option to Google Cloud Functions #3977
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ndmckinley, please review this PR or find an appropriate assignee. |
@@ -179,7 +171,7 @@ func resourceCloudFunctionsFunction() *schema.Resource { | |||
"available_memory_mb": { | |||
Type: schema.TypeInt, | |||
Optional: true, | |||
Default: functionDefaultAllowedMemoryMb, | |||
Default: 256, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why move all these values? It doesn't seem like this is a change from the previous behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it the because those constants aren't doing much. Other resources don't do this
Looks good to me - can you also change the doc in |
Done |
Fixes: hashicorp/terraform-provider-google#7249
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)