Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ingress option to Google Cloud Functions #3977

Merged
merged 5 commits into from
Sep 16, 2020

Conversation

upodroid
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#7249

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudfunctions: added the ALLOW_INTERNAL_AND_GCLB option to `ingress_settings` of `google_cloudfunctions_function` resource.

@google-cla google-cla bot added the cla: yes label Sep 12, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 5 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 1 file changed, 5 insertions(+), 13 deletions(-))

@@ -179,7 +171,7 @@ func resourceCloudFunctionsFunction() *schema.Resource {
"available_memory_mb": {
Type: schema.TypeInt,
Optional: true,
Default: functionDefaultAllowedMemoryMb,
Default: 256,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why move all these values? It doesn't seem like this is a change from the previous behavior.

Copy link
Contributor Author

@upodroid upodroid Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it the because those constants aren't doing much. Other resources don't do this

@nat-henderson
Copy link
Contributor

Looks good to me - can you also change the doc in third_party/terraform/website to add this value to the list of options?

@upodroid
Copy link
Contributor Author

Done

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 6 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 2 files changed, 6 insertions(+), 14 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new ingress option for cloud function
3 participants