Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform 7456 spanner database deletion protection #4117

Conversation

melinath
Copy link
Member

@melinath melinath commented Oct 15, 2020

Fixes hashicorp/terraform-provider-google#7456.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

spanner: added `deletion_protection` field to `google_spanner_database` to make deleting them require an explicit intent.
spanner: `google_spanner_database` resources now cannot be destroyed unless `deletion_protection = false` is set in state for the resource.

@google-cla google-cla bot added the cla: yes label Oct 15, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 36 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 36 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))
Inspec: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152382"

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@melinath melinath force-pushed the terraform-7456-spanner-database-deletion-protection branch from e5d3d65 to a814502 Compare October 16, 2020 16:20
@melinath melinath changed the title WIP: Terraform 7456 spanner database deletion protection Terraform 7456 spanner database deletion protection Oct 16, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 55 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 13 files changed, 55 insertions(+), 21 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))
Inspec: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152568"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 55 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 13 files changed, 55 insertions(+), 21 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))
Inspec: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152568"

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@melinath melinath marked this pull request as draft October 16, 2020 16:31
@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@melinath melinath marked this pull request as ready for review October 16, 2020 17:20
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 111 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 13 files changed, 111 insertions(+), 21 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))
Inspec: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152571"

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, glad you figured out the issue with GetOkExists. This must be the thirtieth time someone on our team has been surprised by that behavior.

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSpannerInstance_basic|TestAccProviderMeta_setModuleName|TestAccBillingBudget_billingBudgetNotifyExample|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_versions|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_update|TestAccComputeRegionHealthCheck_tcp_update|TestAccRegionInstanceGroupManager_stateful|TestAccComputeRouterPeer_basic|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterInterface_withTunnel|TestAccComputeSnapshot_snapshotBasicExample|TestAccComputeSnapshot_encryption|TestAccComputeTargetInstance_targetInstanceBasicExample|TestAccComputeTargetInstance_targetInstanceCustomNetworkExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withSandboxConfig|TestAccContainerNodePool_withSandboxConfig|TestAccDataprocCluster_updatable|TestAccDataprocCluster_withLifecycleConfigIdleDeleteTtl|TestAccDataprocCluster_withAutoscalingPolicy|TestAccDNSPolicy_dnsPolicyBasicExample|TestAccDNSPolicy_update|TestAccIapBrand_iapBrandExample|TestAccIapClient_iapClientExample|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNotebooksInstance_notebookInstanceBasicExample|TestAccNotebooksInstance_notebookInstanceFullExample|TestAccNotebooksInstance_notebookInstanceBasicContainerExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccStorageBucketIamPolicy You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152581"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deletion_protection for google_spanner_database
3 participants