Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cloud scheduler update #4409

Conversation

k-yomo
Copy link
Contributor

@k-yomo k-yomo commented Jan 19, 2021

This PR makes it possible to update cloud scheduler and fixes hashicorp/terraform-provider-google#8159

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudscheduler: Fixed unnecessary recreate for `google_cloud_scheduler_job`

@google-cla google-cla bot added the cla: yes label Jan 19, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

@k-yomo k-yomo force-pushed the feature/support-cloud-scheduler-update branch from 76b64a7 to 0f3a9b1 Compare January 19, 2021 13:48
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 91 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 2 files changed, 91 insertions(+), 34 deletions(-))
Ansible: Diff ( 1 file changed, 23 insertions(+), 23 deletions(-))
Inspec: Diff ( 2 files changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@k-yomo k-yomo changed the title Feature/support cloud scheduler update Support cloud scheduler update Jan 19, 2021
@melinath
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=167868"

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise lgtm; I'll merge pending a successful test run!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 91 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 3 files changed, 92 insertions(+), 35 deletions(-))
Ansible: Diff ( 1 file changed, 23 insertions(+), 23 deletions(-))
Inspec: Diff ( 2 files changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccCloudRunService_cloudRunServiceMultipleEnvironmentVariablesExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=167881"

@melinath
Copy link
Member

The remaining failures seem unrelated to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_cloud_scheduler_job destroyed and recreated instead of update
3 participants