-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Provisioned IOPS support #4578
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ScottSuarez, please review this PR or find an appropriate assignee. |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176389" |
Can we add this to an example/test? |
Piggybacked other tests. Not sure if the values are correct as I can't test it yet. |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177456" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177456" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177456" |
it is out of beta and publicly available, i'll test it properly on Monday https://cloud.google.com/compute/docs/disks/extreme-persistent-disk |
Co-authored-by: upodroid <cy@borg.dev>
This is ready now, the modified test is passing. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 45 insertions(+), 4 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=188247" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeDiskResourcePolicyAttachment_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=188264" |
Fixes: hashicorp/terraform-provider-google#8603
This isn't a public feature yet so I can't test it fully.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)