Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Provisioned IOPS support #4578

Merged
merged 3 commits into from
May 19, 2021

Conversation

upodroid
Copy link
Contributor

@upodroid upodroid commented Mar 9, 2021

Fixes: hashicorp/terraform-provider-google#8603

This isn't a public feature yet so I can't test it fully.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `provisioned_iops` to `google_compute_disk`

@google-cla google-cla bot added the cla: yes label Mar 9, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 8 insertions(+))
Terraform Beta: Diff ( 6 files changed, 83 insertions(+), 2 deletions(-))
Inspec: Diff ( 4 files changed, 7 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176389"

@ScottSuarez
Copy link
Contributor

Can we add this to an example/test?

@upodroid
Copy link
Contributor Author

Piggybacked other tests. Not sure if the values are correct as I can't test it yet.

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177456"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 13 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 6 files changed, 85 insertions(+), 4 deletions(-))
Inspec: Diff ( 4 files changed, 7 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177456"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 13 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 7 files changed, 87 insertions(+), 5 deletions(-))
Inspec: Diff ( 4 files changed, 7 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177456"

@ScottSuarez ScottSuarez requested review from c2thorn and removed request for ScottSuarez March 19, 2021 03:03
@upodroid
Copy link
Contributor Author

it is out of beta and publicly available, i'll test it properly on Monday https://cloud.google.com/compute/docs/disks/extreme-persistent-disk

@upodroid
Copy link
Contributor Author

This is ready now, the modified test is passing.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 45 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 45 insertions(+), 4 deletions(-))
Ansible: Diff ( 2 files changed, 18 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
Inspec: Diff ( 4 files changed, 7 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=188247"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeDiskResourcePolicyAttachment_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=188264"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for provisioned_iops to google_compute_disk
3 participants