Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add field maintenance_window.start_time to google_compute_node_group #4656

Merged
merged 2 commits into from
Apr 5, 2021

Conversation

ScottSuarez
Copy link
Contributor

closes hashicorp/terraform-provider-google#8820

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added field `maintenance_window.start_time` to `google_compute_node_group`

@ScottSuarez ScottSuarez requested review from a team and slevenick and removed request for a team April 2, 2021 17:53
@google-cla google-cla bot added the cla: yes label Apr 2, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 83 insertions(+))
Terraform Beta: Diff ( 3 files changed, 83 insertions(+))
Ansible: Diff ( 2 files changed, 57 insertions(+))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
TF OiCS: Diff ( 1 file changed, 3 insertions(+))
Inspec: Diff ( 5 files changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=180387"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 87 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 87 insertions(+), 4 deletions(-))
Ansible: Diff ( 2 files changed, 57 insertions(+))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
TF OiCS: Diff ( 2 files changed, 5 insertions(+), 2 deletions(-))
Inspec: Diff ( 5 files changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=180392"

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me assuming the tests pass!

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeNodeGroup_nodeGroupAutoscalingPolicyExample|TestAccContainerCluster_withILBSubsetting|TestAccContainerNodePool_regionalAutoscaling|TestAccDataprocCluster_withConfigOverrides You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=180400"

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 87 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 4 files changed, 89 insertions(+), 5 deletions(-))
Ansible: Diff ( 2 files changed, 57 insertions(+))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
TF OiCS: Diff ( 2 files changed, 5 insertions(+), 2 deletions(-))
Inspec: Diff ( 5 files changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=180561"

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 87 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 5 files changed, 89 insertions(+), 7 deletions(-))
Ansible: Diff ( 2 files changed, 57 insertions(+))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
TF OiCS: Diff ( 2 files changed, 5 insertions(+), 2 deletions(-))
Inspec: Diff ( 5 files changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=180866"

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 87 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 4 files changed, 88 insertions(+), 5 deletions(-))
Ansible: Diff ( 2 files changed, 57 insertions(+))
TF Conversion: Diff ( 1 file changed, 29 insertions(+))
TF OiCS: Diff ( 2 files changed, 5 insertions(+), 2 deletions(-))
Inspec: Diff ( 5 files changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=180878"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccComputeNodeGroup_nodeGroupBasicExample|TestAccComputeNodeGroup_nodeGroupAutoscalingPolicyExample|TestAccDataprocCluster_withConfigOverrides You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=180893"

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccComputeNodeGroup_nodeGroupBasicExample|TestAccComputeNodeGroup_nodeGroupAutoscalingPolicyExample|TestAccDataprocCluster_withConfigOverrides|TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR

@ScottSuarez
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for setting maintenance window in google_compute_node_group
3 participants