-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudrun: Check knative observed generation when polling #4793
Cloudrun: Check knative observed generation when polling #4793
Conversation
40c072f
to
d777ef7
Compare
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187894" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187895" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunService_cloudRunServiceUpdate You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187993" |
1 similar comment
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunService_cloudRunServiceUpdate You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187993" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=188046" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readability asks
Hi! I'm the modular magician. Your PR hasn't generated any diffs, but I'll let you know if a future commit does. |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=188664" |
Fixes: hashicorp/terraform-provider-google#8172
See description of the
observedGeneration
field on the REST API: https://cloud.google.com/run/docs/reference/rest/v1/namespaces.domainmappings#DomainMappingStatusClients polling for completed reconciliation should poll until observedGeneration = metadata.generation and the Ready condition's status is True or False.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)