Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudrun: Check knative observed generation when polling #4793

Merged
merged 3 commits into from
May 21, 2021

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented May 17, 2021

Fixes: hashicorp/terraform-provider-google#8172

See description of the observedGeneration field on the REST API: https://cloud.google.com/run/docs/reference/rest/v1/namespaces.domainmappings#DomainMappingStatus

Clients polling for completed reconciliation should poll until observedGeneration = metadata.generation and the Ready condition's status is True or False.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudrun: fixed a bug where resources would return successfully due to responses based on a previous version of the resource

@google-cla google-cla bot added the cla: yes label May 17, 2021
@slevenick slevenick changed the title Check knative observed generation when polling Cloudrun: Check knative observed generation when polling May 17, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 47 insertions(+), 25 deletions(-))
Terraform Beta: Diff ( 3 files changed, 47 insertions(+), 25 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187894"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 47 insertions(+), 25 deletions(-))
Terraform Beta: Diff ( 3 files changed, 47 insertions(+), 25 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187895"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunService_cloudRunServiceUpdate You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187993"

1 similar comment
@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunService_cloudRunServiceUpdate You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187993"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 51 insertions(+), 25 deletions(-))
Terraform Beta: Diff ( 3 files changed, 51 insertions(+), 25 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=188046"

@slevenick slevenick requested review from a team and ScottSuarez and removed request for a team May 20, 2021 02:23
Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readability asks

@slevenick slevenick merged commit 3a48e98 into GoogleCloudPlatform:master May 21, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=188664"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_cloud_run_service knative ready status race condition
3 participants