-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudbuild worker pools #4877
Cloudbuild worker pools #4877
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 2 insertions(+), 12 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192200" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 7 insertions(+), 2 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192377" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 7 insertions(+), 2 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192379" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192379" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192381" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192473" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudbuildWorkerPool_basic|TestAccCloudbuildWorkerPool_withNetwork You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192476" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192738" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccCloudbuildWorkerPool_withNetwork You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192740" |
Tests failed during RECORDING mode: TestAccCloudbuildWorkerPool_withNetwork Please fix these to complete your PR |
Do you have a lint to the rest api docs ? |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192834" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192834" |
mmv1/third_party/terraform/tests/resource_cloudbuild_worker_pool_test.go.erb
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/cloudbuild_worker_pool.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/cloudbuild_worker_pool.html.markdown
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/cloudbuild_worker_pool.html.markdown
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/cloudbuild_worker_pool.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/cloudbuild_worker_pool.html.markdown
Show resolved
Hide resolved
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=193193" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudbuildWorkerPool_withNetwork You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=193197" |
Tests failed during RECORDING mode: TestAccCloudbuildWorkerPool_withNetwork Please fix these to complete your PR |
@@ -126,6 +129,10 @@ type Config struct { | |||
// dataprocBasePath is implemented in mm | |||
EventarcBasePath string | |||
GkeHubBasePath string | |||
<% unless version == 'ga' -%> | |||
// CloudBuild WorkerPool uses a different endpoint (v1beta1) than any other CloudBuild resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of the GA release of Worker Pools, this is no longer the case.
I'm happy to assist if this is not priority, but it appears some work is also needed in declarative-resource-client-library
? @slevenick let me know if this is something that can be tackled outside Google!
Add support for cloudbuild worker pools. Fix some base paths that were defaulting to empty strings
Fixes: hashicorp/terraform-provider-google#8985
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)