Add skip_wait_on_job_termination option for dataflow job resources

[n-oden]

This addresses #10559

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataflow: added `skip_wait_on_job_termination` attribute to `google_dataflow_job` and `google_dataflow_flex_template_job` resources (issue #10559)

[n-oden]

@ScottSuarez this continues from hashicorp/terraform-provider-google#10728

Also, apologies in advance: the test is probably (mostly?) garbage? It passes, but it wasn't really clear to me from example how one would exercise a resource lifecycle change rather than an api change. Any guidance/pointers you could offer would be appreciated.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 166 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 5 files changed, 185 insertions(+), 14 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 166 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 5 files changed, 176 insertions(+), 14 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[n-oden]

@ScottSuarez nudge :)

[ScottSuarez]

/gcbrun

[n-oden]

Hm, I don't appear to have access to the cloudbuild logs for the graphite-docker-images builds.

[ScottSuarez]

hmm, could you pull in latest changes from main?

[n-oden]

done!

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 166 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 5 files changed, 176 insertions(+), 14 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Rerun tests in REPLAYING mode

[modular-magician]

Rerun tests in REPLAYING mode

[modular-magician]

Rerun tests in REPLAYING mode

[modular-magician]

Tests analytics

Total tests: 1967
Passed tests 1710
Skipped tests: 238
Failed tests: 19

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessContextManager|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccComputeRegionUrlMap_defaultUrlRedirectWithinPathMatcher|TestAccComposerEnvironment_composerV2PrivateServiceConnect|TestAccComposerEnvironment_UpdateComposerV2|TestAccComposerEnvironmentAirflow2_withSoftwareConfig|TestAccComposerEnvironment_ComposerV2|TestAccComposerEnvironment_withSoftwareConfig|TestAccComposerEnvironment_composerV2MasterAuthNetworksUpdate|TestAccComposerEnvironment_composerV1MasterAuthNetworksUpdate|TestAccComposerEnvironment_composerV2MasterAuthNetworks|TestAccComposerEnvironment_composerV1MasterAuthNetworks|TestAccRedisInstance_update|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstanceBasicExample|TestAccRedisInstanceDatasource_basic|TestAccRedisInstance_downgradeRedisVersion|TestAccRedisInstance_regionFromLocation|TestAccRedisInstance_redisInstanceAuthEnabled

[n-oden]

hm, looks like the generate-diffs build timed out; can't see anything beyond that.

[ScottSuarez]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 166 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 5 files changed, 176 insertions(+), 14 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1969
Passed tests 1725
Skipped tests: 238
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessContextManager|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccComposerEnvironment_withNodeConfig|TestAccComposerEnvironment_withEncryptionConfig|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

[modular-magician]

Tests passed during RECORDING mode:
TestAccComposerEnvironment_withNodeConfig[view]

Tests failed during RECORDING mode:
TestAccAccessContextManager[view]
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]
TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample[view]
TestAccContainerCluster_withAuthenticatorGroupsConfig[view]
TestAccComposerEnvironment_withEncryptionConfig[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Tests were added that did not run in TeamCity:

• TestAccDataflowJobSkipWait_basic

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccAccessContextManager|TestAccComposerEnvironment_withEncryptionConfig|TestAccComposerEnvironment_withNodeConfig|TestAccComputeForwardingRule_update|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=277542

[n-oden]

Thank you!