Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use skaffold 2.0.2+ in development-guide.md #1447

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Jan 16, 2023

Background

  • When you deploy local Docker images into a kind cluster, those Docker images need to be "loaded" into the kind cluster.
  • The command for loading a Docker image into a kind cluster looks like: kind load docker-image my-local-image
  • When using skaffold run and skaffold dev, skaffold takes care of loading images to kind clusters for us. That is, we don't need to manually run the kind load commands ourselves. See skaffold docs about local clusters.
  • Unfortunately, this "loading" of images was broken in skaffold 1.17.1 (see skaffold/issues/5159) and skaffold 2.0.1 (see microservices-demo/issues/1446).

Fixes

#1446

Change Summary

  • Recommend skaffold 2.0.2+ in development-guide.md.

Testing Procedure

  • I have already tested this on my local machine.

@NimJay NimJay requested a review from a team as a code owner January 16, 2023 16:33
@github-actions
Copy link

🚲 PR staged at http://34.28.133.158

Copy link
Contributor

@xtineskim xtineskim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NimJay NimJay merged commit 740f3e9 into main Jan 19, 2023
@NimJay NimJay deleted the nimjay-development-guide-skaffold branch January 19, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants