Skip to content

Commit

Permalink
Remove basePath: "/" (#589)
Browse files Browse the repository at this point in the history
I'm updating all the openapi files in the getting-started sample in all the sample repos to remove basePath: "/"
Here's the reason from simonz130:

From the OpenAPI 2 spec:
* basePath: "If it is not included, the API is served directly under the host. The value MUST start with a leading slash (/). "
* Paths for methods: "A relative path to an individual endpoint. The field name MUST begin with a slash. The path is appended to the basePath in order to construct the full URL."

This OpenAPI getting-started sample have basePath: "/", which (per strict spec interpretation) means all the paths start with double-slashes. (e.g "//v1/shelves" rather than "/v1/shelves"). Removing basepath="/" fixes that.
  • Loading branch information
navinger authored and jmdobry committed Apr 6, 2018
1 parent 772d408 commit 9828724
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion endpoints/getting-started/openapi-appengine.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ info:
version: "1.0.0"
host: "YOUR-PROJECT-ID.appspot.com"
# [END swagger]
basePath: "/"
consumes:
- "application/json"
produces:
Expand Down

0 comments on commit 9828724

Please sign in to comment.