Add linting for healthcare

Fixes: #836 Fixes: #839
GoogleCloudPlatform · Nov 13, 2018 · c576712 · c576712
1 parent 73861ac
commit c576712
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 7 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -3,4 +3,3 @@ appengine/loopback/*
 functions/**
 iot/*
 appengine/*
-healthcare/*
diff --git a/healthcare/.eslintrc.yml b/healthcare/.eslintrc.yml
@@ -0,0 +1,5 @@
+---
+rules:
+  node/no-unsupported-features/es-syntax: off
+  no-empty: off
+
diff --git a/healthcare/datasets/datasets.js b/healthcare/datasets/datasets.js
@@ -40,7 +40,7 @@ function createDataset(client, projectId, cloudRegion, datasetId) {
 // [END healthcare_create_dataset]
 
 // [START healthcare_delete_dataset]
-function deleteDataset(client, projectId, cloudRegion, datasetId, cb) {
+function deleteDataset(client, projectId, cloudRegion, datasetId) {
   // Client retrieved in callback
   // getClient(serviceAccountJson, function(client) {...});
   // const cloudRegion = 'us-central1';
@@ -160,7 +160,7 @@ function deidentifyDataset(
 
   client.projects.locations.datasets
     .deidentify(request)
-    .then(results => {
+    .then(() => {
       console.log(`De-identified data written from dataset
             ${sourceDatasetId} to dataset ${destinationDatasetId}`);
     })

diff --git a/healthcare/dicom/dicom_stores.js b/healthcare/dicom/dicom_stores.js
@@ -199,7 +199,7 @@ function importDicomObject(
 
   client.projects.locations.datasets.dicomStores
     .import(request)
-    .then(results => {
+    .then(() => {
       console.log(`Imported DICOM objects from bucket ${contentUri}`);
     })
     .catch(err => {
@@ -239,7 +239,7 @@ function exportDicomInstanceGcs(
 
   client.projects.locations.datasets.dicomStores
     .export(request)
-    .then(results => {
+    .then(() => {
       console.log(`Exported DICOM instances to bucket ${uriPrefix}`);
     })
     .catch(err => {

diff --git a/healthcare/dicom/dicomweb.js b/healthcare/dicom/dicomweb.js
@@ -147,7 +147,7 @@ function dicomWebRetrieveStudy(
   };
 
   request(options)
-    .then(results => {
+    .then(() => {
       console.log(`Retrieved study with UID: ${studyUid}`);
     })
     .catch(err => {
@@ -186,7 +186,7 @@ function dicomWebDeleteStudy(
   };
 
   request(options)
-    .then(results => {
+    .then(() => {
       console.log('Deleted study.');
     })
     .catch(err => {