Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.js for node.js 8+ #1273

Closed
wants to merge 1 commit into from

Conversation

nbards
Copy link

@nbards nbards commented May 9, 2019

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 9, 2019
@fhinkel
Copy link
Contributor

fhinkel commented May 11, 2019

@ace-n Could you have a look. Thanks

@ace-n
Copy link
Contributor

ace-n commented May 13, 2019

@nbards can you do the following?

  1. Sign the CLA
  2. Update the comments above the method (to match the new parameters)

Once those are done, I can review this in more detail. Thanks!

@sdenef-adeo
Copy link

Maybe you can close this PR as it is resolved by #1335

@ace-n
Copy link
Contributor

ace-n commented Jul 26, 2019

Thanks for the ping @sdenef-adeo - will close this as it's obsolete.

@ace-n ace-n closed this Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants