Use supertest instead of repo-tools test app #1416
Conversation
googlebot
added
the
cla: yes
|
@bcoe Can you review this? |
kokoro-team
removed
the
kokoro:run
fhinkel
force-pushed
the
repoToolsInHelloWorld
branch
from
8852e17
to
fe2ed3e
Compare
kokoro-team
removed
the
kokoro:run
| @@ -15,15 +15,17 @@ | |||
| "scripts": { | |||
| "deploy": "gcloud app deploy", | |||
| "start": "node app.js", | |||
| "system-test": "repo-tools test app", | |||
| "system-test": "mocha --exit test/*.test.js", | |||
There was a problem hiding this comment.
fun idea which you can take or leave, if you add c8 as a dependency, it turns on Node's V8 coverage collection, so the user gets:
also understand if you think this is too much information for the user all at once.
There was a problem hiding this comment.
Trying to keep dependencies as light as possible.
There was a problem hiding this comment.
But lol, that coverage looks good!
| "test": "npm run system-test", | ||
| "e2e-test": "repo-tools test deploy" | ||
| }, | ||
| "dependencies": { | ||
| "express": "^4.16.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@google-cloud/nodejs-repo-tools": "^3.3.0" | ||
| "@google-cloud/nodejs-repo-tools": "^3.3.0", |
There was a problem hiding this comment.
I think we can delete this dependency now?
There was a problem hiding this comment.
No :) It's used in the e2e-test. But turns out, we're not calling 2e2-test from CI, instead we have special test files that run a deployment. But I'll prefer deleting it in a separate PR. There's a lot of magic happening in repo-tools based on env variables.
| @@ -15,15 +15,17 @@ | |||
| "scripts": { | |||
| "deploy": "gcloud app deploy", | |||
| "start": "node app.js", | |||
| "system-test": "repo-tools test app", | |||
| "system-test": "mocha --exit test/*.test.js", | |||
There was a problem hiding this comment.
The --exit always makes me nervous, but it's not really blocking
There was a problem hiding this comment.
These tests don't finish without --exit
There was a problem hiding this comment.
The default for --exit was changed relatively recently in mocha:
I think it's reasonable to go back to the old default ... alternatively you'd need to capture the server object returned by app.listen and then call .close() on it when tests are complete... sounds like a hassle 😛
There was a problem hiding this comment.
So by using --exit I'm just using Mocha the way it used to be, right?
kokoro-team
removed
the
kokoro:run
Trying to remove
repo-tools. Will send a follow up PR that removesrepo-tools test deploy.Ref: #1247