Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add samples for Data Catalog lookupEntry #1449

Merged
merged 6 commits into from
Aug 14, 2019
Merged

Add samples for Data Catalog lookupEntry #1449

merged 6 commits into from
Aug 14, 2019

Conversation

mesmacosta
Copy link
Contributor

Adding samples to Data Catalog lookup_entry, according to #1447

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 13, 2019
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. Can you add a test file in /.kokoro please. Thanks

@mesmacosta
Copy link
Contributor Author

sure @fhinkel, I added it following the convention of the other samples, let me know if i need to do anything else. Thanks

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 14, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Aug 14, 2019

Awesome, let me configure the CI on our side and run again.

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 14, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Aug 14, 2019

Looks like there are a few linter problems. Can you ran npm run lint -- --fix in the parent directory please. Thanks

/tmpfs/src/github/nodejs-docs-samples/datacatalog/cloud-client/lookupEntry.js
   1:4   error    Delete `·`                                                                    prettier/prettier
  25:1   warning  Expected a function expression                                                func-style
  29:1   error    Delete `⏎`                                                                    prettier/prettier
  34:10  error    Replace `·DataCatalogClient·` with `DataCatalogClient`                        prettier/prettier
  37:3   warning  Expected a function expression                                                func-style
  38:5   warning  Unexpected 'todo' comment                                                     no-warning-comments
  42:22  error    Replace `·linkedResource:·resourceName·` with `linkedResource:·resourceName`  prettier/prettier
  47:12  warning  Prefer await to then()                                                        promise/prefer-await-to-then
  47:30  error    Replace `·console.log(response)` with `⏎····console.log(response);⏎·`         prettier/prettier
/tmpfs/src/github/nodejs-docs-samples/datacatalog/cloud-client/system-test/datacatalog.test.js
   1:4    error  Delete `·`  prettier/prettier
  33:105  error  Insert `;`  prettier/prettier
  35:4    error  Insert `⏎`  prettier/prettier

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 14, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 14, 2019
@mesmacosta
Copy link
Contributor Author

I had to also fix some lint issue on the test file. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants