Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove functions_tips_terminate_node8 #1483

Merged
merged 2 commits into from
Sep 18, 2019
Merged

refactor: Remove functions_tips_terminate_node8 #1483

merged 2 commits into from
Sep 18, 2019

Conversation

grant
Copy link
Contributor

@grant grant commented Sep 16, 2019

Remove unused and non-unique sample 1373.

@grant grant requested a review from ace-n September 16, 2019 14:40
@grant grant self-assigned this Sep 16, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 16, 2019
@grant
Copy link
Contributor Author

grant commented Sep 16, 2019

This unrelated test fails:

  • Internal CI (run/logging-manual) — Tests failed.

@grant grant added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2019
@grant
Copy link
Contributor Author

grant commented Sep 18, 2019

@ace-n PTAL.

ace-n
ace-n approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if related tests pass.

Side note: we can probably remove the _node8 samples, now that Node 6 is on its own branch.

@grant grant merged commit 33bdcf5 into master Sep 18, 2019
@grant grant deleted the grant-functions_tips_terminate_node8 branch September 18, 2019 19:09
This was referenced Jun 19, 2022
Open
Open
@leejh3224 leejh3224 mentioned this pull request Jun 20, 2022
Open
This was referenced Jun 20, 2022
Open
Open
Open
@ninadhatkar ninadhatkar mentioned this pull request Jun 20, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n approved these changes

Assignees

@grant grant

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grant @ace-n @googlebot @kokoro-team