migrate code from googleapis/nodejs-cloudbuild #2824

grayside · 2022-11-10T19:15:57Z

feat: initial release of cloud build library (Add linting. #2)
feat(docs): add listBuildTriggers sample to README (add appengine samples #5)
feat: moves library to TypeScript code generation (Add appengine/ghost sample #10)
chore: release 1.0.0 (Be more explicit with my english. #3)
chore: release 1.1.0 (Add integration tests that check that samples run #20)
chore: update license headers
chore: release 1.2.0 (clean up memcache sample #25)
chore: release 1.3.0 (Added back datastore v1beta3 samples. #33)
chore(deps): update dependency c8 to v7 (Add webpack sample #38)
refactor: use explicit mocha imports (Simplify app.yaml files, reduce # of e2e tests, and cleanup for webpa… #40)
chore(deps): update dependency mocha to v7 (Rename to mongodb and update readme. #43)
chore: release 1.3.1
chore: release 1.3.2 (Use a port picker to prevent port reuse #49)
chore: release 1.3.3 (Add logging example and link to instructions for Compute Engine as well #59)
chore: release 1.4.0 (Parse-server sample for Google App Engine not recognizing variables in yaml #63)
chore: release 1.5.0 (Google Cloud Functions - Node.js Version #67)
chore(deps): update dependency mocha to v8 (Strings! #122)
chore: release 2.0.0 (Delete server.js #92)
chore: release 2.0.1 (memcache samples should use right env vars #126)
chore: release 2.0.2 (Changed helloworld to camel case #133)
chore: release 2.0.3 (Switch back to mocha from ava. #143)
chore: release 2.0.4 (Language API samples #179)
chore: release 2.0.5 (All Storage samples are now up to standard. #182)
chore: release 2.0.6 (Export data from BigQuery samples #186)
chore: release 2.1.0 (allow bower to run as root to fix deployment failure (issue 204) #205)
chore: release 2.2.0 (gcloud app logs read ERROR: gcloud crashed (ValueError): time data does not match format #213)
chore: release 2.2.1 (Add message ordering samples #220)
chore: release 2.2.2 (Add callback type-checking to tests #227)
chore: release 2.2.3 (Error: Audio 'content' cannot be longer than 1 min. For long audio, use the 'uri' parameter to specify a file. #232)
chore: release 2.2.4 (Revert "Upgrade apps for env:flex." #242)
chore: release 2.2.5 ( Copied Endpoints Echo sample from /appengine/endpoints #247)
chore: release 2.2.6 (@google-cloud/datastore 0.5.0 does not return entity keys with query results #250)
chore: release 2.2.7 (Update Cloud Functions error sample to use the Error Reporting module #252)
chore: release 2.3.0 (Update storage samples. #263)
chore: release 2.3.1 (Enable auto table creation in Google Cloud Functions SendGrid tutorial #266)
chore: release 2.3.2 (Botkit-based NL API bot #269)
chore: release 2.4.0 (Botkit-based NL API bot #270)
chore: release 2.5.0 (Update Endpoints samples: #272)
chore: release 2.6.0 (Speech sample: Error: spawn rec ENOENT with listen option #275)
docs(samples): add example tags to generated samples (Error while deploying Nodejs Express framework sample application to AppEngine #287)
chore(quickstart): mention private pool caveats (Updated readWriteTransaction to fix bug #317)
build!: update library to use Node 12 (Fix issue with read-only transaction #325)
chore(main): release 3.0.0 (Fixed some typos in tables.js #326)
chore(main): release 3.0.1 (chore: update docker in containerengine example #328)
chore(main): release 3.1.0 (Updated the version of spanner library #334)
chore(main): release 3.1.1 (Update translate dependency #340)
chore(main): release 3.1.2 (Update yarn version #345)

google-cla · 2022-11-10T19:16:08Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

snippet-bot · 2022-11-10T19:56:04Z

Here is the summary of changes.

You are about to add 2 region tags.

cloudbuild/listBuildTriggers.js:22, tag cloudbuild_list_build_triggers
cloudbuild/quickstart.js:18, tag cloudbuild_quickstart

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

NimJay · 2022-11-10T19:59:31Z

.github/workflows/workflows.json

@@ -17,6 +17,7 @@
  "appengine/typescript",
  "appengine/websockets",
  "appengine/twilio",
+  "cloudbuild",


Nitpick (feel free to ignore):
Should the folder name be cloud-build to be consistent with existing cloud-* folders in this repo?

I'm aligning with the the product API name and region tag, and think it's a minor bug where other directories don't but not necessarily worth fixing.

NimJay · 2022-11-10T20:05:37Z

I have overridden the CLA check. ✅

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mocha](https://mochajs.org/) ([source](https://github.com/mochajs/mocha)) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/mocha/7.2.0/8.0.1) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v8.0.1`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#801--2020-06-10) [Compare Source](https://github.com/mochajs/mocha/compare/v8.0.0...v8.0.1) The obligatory patch after a major. #### 🐛 Fixes - [#4328](https://github.com/mochajs/mocha/issues/4328): Fix `--parallel` when combined with `--watch` ([**@boneskull**](https://github.com/boneskull)) ### [`v8.0.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#800--2020-06-10) [Compare Source](https://github.com/mochajs/mocha/compare/v7.2.0...v8.0.0) In this major release, Mocha adds the ability to _run tests in parallel_. Better late than never! Please note the **breaking changes** detailed below. Let's welcome [**@giltayar**](https://github.com/giltayar) and [**@nicojs**](https://github.com/nicojs) to the maintenance team! #### 💥 Breaking Changes - [#4164](https://github.com/mochajs/mocha/issues/4164): **Mocha v8.0.0 now requires Node.js v10.0.0 or newer.** Mocha no longer supports the Node.js v8.x line ("Carbon"), which entered End-of-Life at the end of 2019 ([**@UlisesGascon**](https://github.com/UlisesGascon)) - [#4175](https://github.com/mochajs/mocha/issues/4175): Having been deprecated with a warning since v7.0.0, **`mocha.opts` is no longer supported** ([**@juergba**](https://github.com/juergba)) ✨ **WORKAROUND:** Replace `mocha.opts` with a [configuration file](https://mochajs.org/#configuring-mocha-nodejs). - [#4260](https://github.com/mochajs/mocha/issues/4260): Remove `enableTimeout()` (`this.enableTimeout()`) from the context object ([**@craigtaub**](https://github.com/craigtaub)) ✨ **WORKAROUND:** Replace usage of `this.enableTimeout(false)` in your tests with `this.timeout(0)`. - [#4315](https://github.com/mochajs/mocha/issues/4315): The `spec` option no longer supports a comma-delimited list of files ([**@juergba**](https://github.com/juergba)) ✨ **WORKAROUND**: Use an array instead (e.g., `"spec": "foo.js,bar.js"` becomes `"spec": ["foo.js", "bar.js"]`). - [#4309](https://github.com/mochajs/mocha/issues/4309): Drop support for Node.js v13.x line, which is now End-of-Life ([**@juergba**](https://github.com/juergba)) - [#4282](https://github.com/mochajs/mocha/issues/4282): `--forbid-only` will throw an error even if exclusive tests are avoided via `--grep` or other means ([**@arvidOtt**](https://github.com/arvidOtt)) - [#4223](https://github.com/mochajs/mocha/issues/4223): The context object's `skip()` (`this.skip()`) in a "before all" (`before()`) hook will no longer execute subsequent sibling hooks, in addition to hooks in child suites ([**@juergba**](https://github.com/juergba)) - [#4178](https://github.com/mochajs/mocha/issues/4178): Remove previously soft-deprecated APIs ([**@wnghdcjfe**](https://github.com/wnghdcjfe)): - `Mocha.prototype.ignoreLeaks()` - `Mocha.prototype.useColors()` - `Mocha.prototype.useInlineDiffs()` - `Mocha.prototype.hideDiff()` #### 🎉 Enhancements - [#4245](https://github.com/mochajs/mocha/issues/4245): Add ability to run tests in parallel for Node.js (see [docs](https://mochajs.org/#parallel-tests)) ([**@boneskull**](https://github.com/boneskull)) ❗ See also [#4244](https://github.com/mochajs/mocha/issues/4244); [Root Hook Plugins (docs)](https://mochajs.org/#root-hook-plugins) -- _root hooks must be defined via Root Hook Plugins to work in parallel mode_ - [#4304](https://github.com/mochajs/mocha/issues/4304): `--require` now works with ES modules ([**@JacobLey**](https://github.com/JacobLey)) - [#4299](https://github.com/mochajs/mocha/issues/4299): In some circumstances, Mocha can run ES modules under Node.js v10 -- _use at your own risk!_ ([**@giltayar**](https://github.com/giltayar)) #### 📖 Documentation - [#4246](https://github.com/mochajs/mocha/issues/4246): Add documentation for parallel mode and Root Hook plugins ([**@boneskull**](https://github.com/boneskull)) #### 🐛 Fixes (All bug fixes in Mocha v8.0.0 are also breaking changes, and are listed above) </details> --- ### Renovate configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-cloudbuild).

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.0.2](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.0.1...v2.0.2) (2020-07-09) ### Bug Fixes * typeo in nodejs .gitattribute ([#132](https://www.github.com/googleapis/nodejs-cloudbuild/issues/132)) ([80b5bd9](https://www.github.com/googleapis/nodejs-cloudbuild/commit/80b5bd963aa43e5a47da9e6d0e2ffbf0cde7feef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.2.4](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.2.3...v2.2.4) (2021-06-24) ### Bug Fixes * make request optional in all cases ([#241](https://www.github.com/googleapis/nodejs-cloudbuild/issues/241)) ([c96003a](https://www.github.com/googleapis/nodejs-cloudbuild/commit/c96003a4897d3f7c8181a56c273b842a4dcdfbf7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.2.7](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.2.6...v2.2.7) (2021-07-21) ### Bug Fixes * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#251](https://www.github.com/googleapis/nodejs-cloudbuild/issues/251)) ([7bc5f7f](https://www.github.com/googleapis/nodejs-cloudbuild/commit/7bc5f7ff6c1485baaf1444a608d8ebb88ad20cfe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.1](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.3.0...v2.3.1) (2021-08-12) ### Bug Fixes * **build:** migrate to using main branch ([#265](https://www.github.com/googleapis/nodejs-cloudbuild/issues/265)) ([e89f829](https://www.github.com/googleapis/nodejs-cloudbuild/commit/e89f829f10c5710ca5fb259a6c8dfae1527071a3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.2](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.3.1...v2.3.2) (2021-08-16) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#268](https://www.github.com/googleapis/nodejs-cloudbuild/issues/268)) ([c26f7f7](https://www.github.com/googleapis/nodejs-cloudbuild/commit/c26f7f726db4f43f3692aea4c516547abcddd0ea)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ## [2.4.0](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.3.2...v2.4.0) (2021-08-16) ### Features * Add ability to configure BuildTriggers to create Builds that require approval before executing and ApproveBuild API to approve or reject pending Builds ([#267](https://www.github.com/googleapis/nodejs-cloudbuild/issues/267)) ([18ec067](https://www.github.com/googleapis/nodejs-cloudbuild/commit/18ec067ac1e112836c5d56747dda89e04f87c481)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ## [2.5.0](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.4.0...v2.5.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#271](https://www.github.com/googleapis/nodejs-cloudbuild/issues/271)) ([dcb970d](https://www.github.com/googleapis/nodejs-cloudbuild/commit/dcb970d8a6a7d87da553667cd25f8eb1052ba047)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* docs(samples): add example tags to generated samples PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: https://github.com/googleapis/googleapis-gen/commit/eb888bc214efc7bf43bf4634b470254565a659a5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: change node version for sample Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com>

* feat!: Update library to use Node 12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 3.0.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [3.0.1](googleapis/nodejs-cloudbuild@v3.0.0...v3.0.1) (2022-06-20) ### Bug Fixes * fixes for dynamic routing and streaming descriptors ([#327](googleapis/nodejs-cloudbuild#327)) ([4cf9b63](googleapis/nodejs-cloudbuild@4cf9b63)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* chore(main): release 3.1.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 3.1.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 3.1.2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

ace-n

Two questions:

Does quickstart.js belong with the library (in the google-cloud-node repo)?
Do we need to update CODEOWNERS?

grayside · 2022-11-10T22:34:05Z

Per discussion, the quickstart should be forked because it's used in the docs. It will also move to the library as a test case.

ace-n · 2022-11-10T23:25:45Z

Admin-merging to override CLA bot 👍

product-auto-label bot added the samples Issues that are directly related to samples. label Nov 10, 2022

grayside marked this pull request as ready for review November 10, 2022 19:55

grayside requested review from a team as code owners November 10, 2022 19:55

NimJay reviewed Nov 10, 2022

View reviewed changes

kweinmeister approved these changes Nov 10, 2022

View reviewed changes

NimJay approved these changes Nov 10, 2022

View reviewed changes

bcoe and others added 20 commits November 10, 2022 13:24

feat: initial release of cloud build library (#2)

5a73471

feat(docs): add listBuildTriggers sample to README (#5)

0c512cd

feat: moves library to TypeScript code generation (#10)

a367efc

chore: release 1.0.0 (#3)

19ed643

chore: release 1.1.0 (#20)

1e12e42

chore: update license headers

ac902f3

chore: release 1.2.0 (#25)

0b3af8f

chore: release 1.3.0 (#33)

4e6cbc0

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

chore(deps): update dependency c8 to v7 (#38)

4922427

refactor: use explicit mocha imports (#40)

c1b675c

chore(deps): update dependency mocha to v7 (#43)

2c638c1

chore: release 1.3.1

aedda70

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

chore: release 1.3.2 (#49)

450c95a

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

chore: release 1.3.3 (#59)

d8d1c22

chore: release 1.4.0 (#63)

f1be19e

chore: release 1.5.0 (#67)

abfae12

chore: release 2.0.1 (#126)

086df83

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

release-please bot and others added 21 commits November 10, 2022 13:24

chore: release 2.2.2 (#227)

7d64856

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

chore: release 2.2.3 (#232)

ead65b5

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

chore: release 2.2.5 (#247)

0344b08

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

chore: release 2.2.6 (#250)

e9be6a8

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

chore: release 2.6.0 (#275)

b36e0f4

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

chore(quickstart): mention private pool caveats (#317)

790f4da

testing(cloudbuild): Add GitHub Workflows integration for test running

200a250

ace-n force-pushed the nodejs-cloudbuild-migration branch from 88c4d97 to 200a250 Compare November 10, 2022 21:24

ace-n suggested changes Nov 10, 2022

View reviewed changes

chore(CODEOWNERS): Add cloudbuild ownership

7572697

Merge branch 'main' into nodejs-cloudbuild-migration

65cecaf

ace-n approved these changes Nov 10, 2022

View reviewed changes

ace-n merged commit f03f09a into main Nov 10, 2022

ace-n deleted the nodejs-cloudbuild-migration branch November 10, 2022 23:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migrate code from googleapis/nodejs-cloudbuild #2824

migrate code from googleapis/nodejs-cloudbuild #2824

grayside commented Nov 10, 2022

google-cla bot commented Nov 10, 2022

snippet-bot bot commented Nov 10, 2022 •

edited

Loading

NimJay Nov 10, 2022

grayside Nov 10, 2022

NimJay commented Nov 10, 2022

ace-n left a comment

grayside commented Nov 10, 2022

ace-n commented Nov 10, 2022

migrate code from googleapis/nodejs-cloudbuild #2824

migrate code from googleapis/nodejs-cloudbuild #2824

Conversation

grayside commented Nov 10, 2022

google-cla bot commented Nov 10, 2022

snippet-bot bot commented Nov 10, 2022 • edited Loading

NimJay Nov 10, 2022

Choose a reason for hiding this comment

grayside Nov 10, 2022

Choose a reason for hiding this comment

NimJay commented Nov 10, 2022

ace-n left a comment

Choose a reason for hiding this comment

grayside commented Nov 10, 2022

ace-n commented Nov 10, 2022

snippet-bot bot commented Nov 10, 2022 •

edited

Loading