Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linkinator): skip localhost URLs #2847

Merged
merged 2 commits into from
Nov 15, 2022
Merged

chore(linkinator): skip localhost URLs #2847

merged 2 commits into from
Nov 15, 2022

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Nov 14, 2022

No description provided.

@ace-n ace-n requested review from a team as code owners November 14, 2022 20:36
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 14, 2022
Copy link
Contributor

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
I'm guessing the goal here is to resolve the failing test in #2841 and #2850:

Run JustinBeckwith/linkinator-action@v1

...

 appengine/README.md
   [0] http://localhost:8080/

@ace-n ace-n enabled auto-merge (rebase) November 15, 2022 18:00
@ace-n ace-n merged commit e7c19e7 into main Nov 15, 2022
@ace-n ace-n deleted the skip-localhost branch November 15, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants