migrate code from googleapis/nodejs-security-center #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Release v0.1.1 * Update CHANGELOG.md
* samples: add quickstart * sync quickstart to README.md * rm console.log * update README.md * npm run fix
chore(deps): update dependency mocha to v6 This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | mocha | devDependencies | major | `^5.2.0` -> `^6.0.0` | [homepage](https://mochajs.org/), [source](https://github.com/mochajs/mocha) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v6.0.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#​600--2019-02-18) [Compare Source](https://github.com/mochajs/mocha/compare/v5.2.0...v6.0.0) #### 🎉 Enhancements - [#​3726](https://github.com/mochajs/mocha/issues/3726): Add ability to unload files from `require` cache ([**@​plroebuck**](https://github.com/plroebuck)) #### 🐛 Fixes - [#​3737](https://github.com/mochajs/mocha/issues/3737): Fix falsy values from options globals ([**@​plroebuck**](https://github.com/plroebuck)) - [#​3707](https://github.com/mochajs/mocha/issues/3707): Fix encapsulation issues for `Suite#_onlyTests` and `Suite#_onlySuites` ([**@​vkarpov15**](https://github.com/vkarpov15)) - [#​3711](https://github.com/mochajs/mocha/issues/3711): Fix diagnostic messages dealing with plurality and markup of output ([**@​plroebuck**](https://github.com/plroebuck)) - [#​3723](https://github.com/mochajs/mocha/issues/3723): Fix "reporter-option" to allow comma-separated options ([**@​boneskull**](https://github.com/boneskull)) - [#​3722](https://github.com/mochajs/mocha/issues/3722): Fix code quality and performance of `lookupFiles` and `files` ([**@​plroebuck**](https://github.com/plroebuck)) - [#​3650](https://github.com/mochajs/mocha/issues/3650), [#​3654](https://github.com/mochajs/mocha/issues/3654): Fix noisy error message when no files found ([**@​craigtaub**](https://github.com/craigtaub)) - [#​3632](https://github.com/mochajs/mocha/issues/3632): Tests having an empty title are no longer confused with the "root" suite ([**@​juergba**](https://github.com/juergba)) - [#​3666](https://github.com/mochajs/mocha/issues/3666): Fix missing error codes ([**@​vkarpov15**](https://github.com/vkarpov15)) - [#​3684](https://github.com/mochajs/mocha/issues/3684): Fix exiting problem in Node.js v11.7.0+ ([**@​addaleax**](https://github.com/addaleax)) - [#​3691](https://github.com/mochajs/mocha/issues/3691): Fix `--delay` (and other boolean options) not working in all cases ([**@​boneskull**](https://github.com/boneskull)) - [#​3692](https://github.com/mochajs/mocha/issues/3692): Fix invalid command-line argument usage not causing actual errors ([**@​boneskull**](https://github.com/boneskull)) - [#​3698](https://github.com/mochajs/mocha/issues/3698), [#​3699](https://github.com/mochajs/mocha/issues/3699): Fix debug-related Node.js options not working in all cases ([**@​boneskull**](https://github.com/boneskull)) - [#​3700](https://github.com/mochajs/mocha/issues/3700): Growl notifications now show the correct number of tests run ([**@​outsideris**](https://github.com/outsideris)) - [#​3686](https://github.com/mochajs/mocha/issues/3686): Avoid potential ReDoS when diffing large objects ([**@​cyjake**](https://github.com/cyjake)) - [#​3715](https://github.com/mochajs/mocha/issues/3715): Fix incorrect order of emitted events when used programmatically ([**@​boneskull**](https://github.com/boneskull)) - [#​3706](https://github.com/mochajs/mocha/issues/3706): Fix regression wherein `--reporter-option`/`--reporter-options` did not support comma-separated key/value pairs ([**@​boneskull**](https://github.com/boneskull)) #### 📖 Documentation - [#​3652](https://github.com/mochajs/mocha/issues/3652): Switch from Jekyll to Eleventy ([**@​Munter**](https://github.com/Munter)) #### 🔩 Other - [#​3677](https://github.com/mochajs/mocha/issues/3677): Add error objects for createUnsupportedError and createInvalidExceptionError ([**@​boneskull**](https://github.com/boneskull)) - [#​3733](https://github.com/mochajs/mocha/issues/3733): Removed unnecessary processing in post-processing hook ([**@​wanseob**](https://github.com/wanseob)) - [#​3730](https://github.com/mochajs/mocha/issues/3730): Update nyc to latest version ([**@​coreyfarrell**](https://github.com/coreyfarrell)) - [#​3648](https://github.com/mochajs/mocha/issues/3648), [#​3680](https://github.com/mochajs/mocha/issues/3680): Fixes to support latest versions of [unexpected](https://npm.im/unexpected) and [unexpected-sinon](https://npm.im/unexpected-sinon) ([**@​sunesimonsen**](https://github.com/sunesimonsen)) - [#​3638](https://github.com/mochajs/mocha/issues/3638): Add meta tag to site ([**@​MartijnCuppens**](https://github.com/MartijnCuppens)) - [#​3653](https://github.com/mochajs/mocha/issues/3653): Fix parts of test suite failing to run on Windows ([**@​boneskull**](https://github.com/boneskull)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#googleapis/nodejs-security-center). #54 automerged by dpebot
This pull request was generated using releasetool.
refactor: use execSync for tests #80 automerged by dpebot
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
* chore(main): release 5.11.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* build!: Update library to use Node 12 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore(main): release 6.2.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore(main): release 6.3.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore(main): release 6.3.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
product-auto-label
bot
added
the
samples
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
NimJay
reviewed
Nov 17, 2022
.eslintrc.yml
Outdated
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| rules: | |||
| no-console: off | |||
There was a problem hiding this comment.
Suggestion: Try moving this .eslintrc.yml file to the security-center/snippets directory. That might resolve the ESlint issues.
There was a problem hiding this comment.
Ohhh, good catch. I noticed this and wondered if it should be migrated with everything else; but then it slipped my mind when this error came up. Thanks for pointing that out for me!
NimJay
reviewed
Nov 18, 2022
unforced
force-pushed
the
nodejs-security-center-migration
branch
from
841becc to
fb09fa0
Compare
Co-authored-by: Nim Jayawardena <i.am.nim.jay@gmail.com>
NimJay
reviewed
Nov 18, 2022
| "scheduler", | ||
| "security-center/snippets", | ||
| "service-directory/snippets", |
There was a problem hiding this comment.
Praise: Thanks for fixing the order here. :)
NimJay
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Thank you so much, Aaron, for working through this friction.
This migration was definitely one of the more difficult ones. :(
LGTM! :)
CLA overridden.
Now we just need approval from https://github.com/orgs/googleapis/teams/nodejs-samples-reviewers.
ace-n
approved these changes
Nov 18, 2022
|
Thanks for the review/approval, Ace! Looks like we can't merge via "Rebase and merge".
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google-cloudfromgcloud#235)topic.existsmethod does not resolve promise #310)