Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: matching test names with region tags per enforcer requirements #3108

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

pattishin
Copy link
Contributor

Issue: Resolving region-tags workflow failures in appengine that is popping up in PRs

Example: https://github.com/GoogleCloudPlatform/nodejs-docs-samples/actions/runs/4623711080/jobs/8177808534?pr=3104

Screenshot 2023-04-06 at 12 19 55 PM

Resolution: Expects any written tests to match names with region tags of samples

https://github.com/GoogleCloudPlatform/repo-automation-playground/tree/master/xunit-ci-enforcer

@pattishin pattishin requested review from a team as code owners April 6, 2023 19:22
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Apr 6, 2023
@pattishin pattishin merged commit 11205f4 into main Apr 6, 2023
@pattishin pattishin deleted the fix/appengine-region-tag-match-fix branch April 6, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants