Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLP: Added sample for create and get job #3361

Merged
merged 4 commits into from
Aug 8, 2023
Merged

Conversation

dinesh-crest
Copy link
Contributor

Description

References:- https://cloud.google.com/dlp/docs/samples/dlp-create-job
https://cloud.google.com/dlp/docs/samples/dlp-get-job

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@dinesh-crest dinesh-crest requested review from a team as code owners July 25, 2023 12:41
@snippet-bot
Copy link

snippet-bot bot commented Jul 25, 2023

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: dlp Issues related to the Sensitive Data Protection API. samples Issues that are directly related to samples. labels Jul 25, 2023
@dinesh-crest dinesh-crest force-pushed the create_get_job_samples branch from b56d0f2 to 90cdabb Compare July 28, 2023 12:14
@annadata annadata assigned annadata and unassigned manjaepark Aug 1, 2023
dlp/createJob.js Outdated Show resolved Hide resolved
@pattishin
Copy link
Contributor

@dinesh-crest Happy to get this in for you - I do believe there is one more comment that needs to be resolved before this can be merged in.

@dinesh-crest dinesh-crest force-pushed the create_get_job_samples branch from f7d6d3a to 11c3cc0 Compare August 7, 2023 11:05
@annadata annadata force-pushed the create_get_job_samples branch from 11c3cc0 to 0151896 Compare August 8, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dlp Issues related to the Sensitive Data Protection API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants